From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757672AbdKGQAd (ORCPT ); Tue, 7 Nov 2017 11:00:33 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47235 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752695AbdKGQAB (ORCPT ); Tue, 7 Nov 2017 11:00:01 -0500 Date: Tue, 7 Nov 2017 16:59:47 +0100 From: Andrew Lunn To: Vladimir Zapolskiy Cc: Chris Zhong , Sergei Shtylyov , Roger Quadros , Mark Rutland , devicetree@vger.kernel.org, heiko@sntech.de, netdev@vger.kernel.org, Russell King , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac Message-ID: <20171107155947.GC18410@lunn.ch> References: <1510022959-19440-1-git-send-email-zyw@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > As a side question, which is mainly addressed to Sergei and Roger, > I don't quite understand why PHY properties were initially added to > MAC/MDIO bus device tree nodes, in my opinion they must be moved under > PHY device tree nodes. If you look at the implementation, they are not actually PHY properties. They are MDIO properties. It is the MDIO driver using them to perform an 'MDIO bus reset'. The property names are wrong. The device tree structure could be better. It mixes the MAC and the MDIO properties in the same node. It would of been better to have separate nodes. The MDIO core now has equivalent functionality. So yes, it would be better to use the generic MDIO properties, not these driver properties. Andrew