From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933029AbdKGStR (ORCPT ); Tue, 7 Nov 2017 13:49:17 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:44918 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdKGStQ (ORCPT ); Tue, 7 Nov 2017 13:49:16 -0500 From: Colin King To: Evgeniy Polyakov Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] w1: remove redundant assignments to search_bit and last_rn Date: Tue, 7 Nov 2017 18:49:14 +0000 Message-Id: <20171107184914.7561-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King Variables search_bit and last_rn are assigned values before a while-loop however these initial values are never read (as they are overwritten inside the loop). Thus these initial assignments are redundant and can be removed. Cleans up clang warnings: drivers/w1/w1.c:967:2: warning: Value stored to 'search_bit' is never read drivers/w1/w1.c:969:2: warning: Value stored to 'last_rn' is never read Signed-off-by: Colin Ian King --- drivers/w1/w1.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 0c2a5a8327bd..c29f6c5dda3c 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -964,9 +964,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb int search_bit, desc_bit; u8 triplet_ret = 0; - search_bit = 0; rn = dev->search_id; - last_rn = 0; last_device = 0; last_zero = -1; -- 2.14.1