From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753492AbdKGTnD (ORCPT ); Tue, 7 Nov 2017 14:43:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:37309 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753176AbdKGTnC (ORCPT ); Tue, 7 Nov 2017 14:43:02 -0500 Date: Tue, 7 Nov 2017 20:43:01 +0100 From: "Luis R. Rodriguez" To: Himanshu Jha Cc: linux-kernel@vger.kernel.org, mcgrof@kernel.org Subject: Re: [PATCH] firmware: raspberrypi: Eliminate use of time_to_tm Message-ID: <20171107194301.GC22894@wotan.suse.de> References: <1509832306-1104-1-git-send-email-himanshujha199640@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1509832306-1104-1-git-send-email-himanshujha199640@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 05, 2017 at 03:21:46AM +0530, Himanshu Jha wrote: > time_to_tm function is deprecated due to y2038 problem, therefore use > time64_to_tm instead. Use ./scripts/get_maintainer.pl foo.patch and resend with the respective folks addressed to as needed (To or Cc as indicated by the script). Your commit log should reference why *time_to_tm()* is now deprecated in favor for time64_to_tm() to make maintainer's lives easier so that their lookup is faster. Resend with these details. Likewise for the other patches for which you failed to do any of this for. Luis > Signed-off-by: Himanshu Jha > --- > drivers/firmware/raspberrypi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c > index dd506cd..aa4c797 100644 > --- a/drivers/firmware/raspberrypi.c > +++ b/drivers/firmware/raspberrypi.c > @@ -166,7 +166,7 @@ EXPORT_SYMBOL_GPL(rpi_firmware_property); > static void > rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) > { > - u32 packet; > + time64_t packet; > int ret = rpi_firmware_property(fw, > RPI_FIRMWARE_GET_FIRMWARE_REVISION, > &packet, sizeof(packet)); > @@ -174,7 +174,7 @@ rpi_firmware_print_firmware_revision(struct rpi_firmware *fw) > if (ret == 0) { > struct tm tm; > > - time_to_tm(packet, 0, &tm); > + time64_to_tm(packet, 0, &tm); > > dev_info(fw->cl.dev, > "Attached to firmware from %04ld-%02d-%02d %02d:%02d\n", > -- > 2.7.4 > > -- Luis Rodriguez, SUSE LINUX GmbH Maxfeldstrasse 5; D-90409 Nuernberg