From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbdKHJrL (ORCPT ); Wed, 8 Nov 2017 04:47:11 -0500 Received: from sym2.noone.org ([178.63.92.236]:43801 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751306AbdKHJrJ (ORCPT ); Wed, 8 Nov 2017 04:47:09 -0500 Date: Wed, 8 Nov 2017 10:47:06 +0100 From: Tobias Klauser To: Greentime Hu Cc: greentime@andestech.com, linux-kernel@vger.kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, robh+dt@kernel.org, netdev@vger.kernel.org, Rick Chen Subject: Re: [PATCH 03/31] nds32: Support early_printk Message-ID: <20171108094705.GK1370@distanz.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-11-08 at 06:54:51 +0100, Greentime Hu wrote: > From: Greentime Hu > > Signed-off-by: Rick Chen > Signed-off-by: Greentime Hu > --- > arch/nds32/kernel/early_printk.c | 124 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 124 insertions(+) > create mode 100644 arch/nds32/kernel/early_printk.c > > diff --git a/arch/nds32/kernel/early_printk.c b/arch/nds32/kernel/early_printk.c > new file mode 100644 > index 0000000..269c3cd > --- /dev/null > +++ b/arch/nds32/kernel/early_printk.c Could be implemented using earlycon (the 8250 drivers already supports it) instead of duplicating functionality in arch/nds32? See e.g. the nios2 port for how this could be done, specifically commit e118c3fec9c0 ("nios2: remove custom early console implementation").