From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbdKHKni (ORCPT ); Wed, 8 Nov 2017 05:43:38 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:43426 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbdKHKnf (ORCPT ); Wed, 8 Nov 2017 05:43:35 -0500 X-Google-Smtp-Source: ABhQp+R+U6VpvOYQKtFw4G1Aa/pp+9ZO9I0nPIUoeHX1giQntaMxjh60DOsLEEBmNR+aApoAIyDZUw== Date: Wed, 8 Nov 2017 10:43:31 +0000 From: Lee Jones To: Colin King Cc: Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] backlight: ili922x: remove redundant variable len Message-ID: <20171108104331.phpfymg2kslgwg3v@dell> References: <20171105115326.5276-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171105115326.5276-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 05 Nov 2017, Colin King wrote: > From: Colin Ian King > > The variable len is assigned but never read, therefore it is redundant > and can be removed. Cleans up clang warning: > > drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len' > is never read > > Signed-off-by: Colin Ian King > --- > drivers/video/backlight/ili922x.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > index a9e9cef..2b6c6aa 100644 > --- a/drivers/video/backlight/ili922x.c > +++ b/drivers/video/backlight/ili922x.c > @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) > struct spi_transfer xfer_regindex, xfer_regvalue; > unsigned char tbuf[CMD_BUFSIZE]; > unsigned char rbuf[CMD_BUFSIZE]; > - int ret, len = 0; > + int ret; > > memset(&xfer_regindex, 0, sizeof(struct spi_transfer)); > memset(&xfer_regvalue, 0, sizeof(struct spi_transfer)); > @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value) > ret = spi_sync(spi, &msg); > > spi_message_init(&msg); > - len = 0; > tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG, > START_RW_WRITE)); > tbuf[1] = set_tx_byte((value & 0xFF00) >> 8); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog