From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbdKHQUL (ORCPT ); Wed, 8 Nov 2017 11:20:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:58060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbdKHQUK (ORCPT ); Wed, 8 Nov 2017 11:20:10 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0A04217C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 8 Nov 2017 11:20:07 -0500 From: Steven Rostedt To: Tejun Heo Cc: Sergey Senozhatsky , Petr Mladek , linux-kernel@vger.kernel.org, kernel-team@fb.com, Linus Torvalds , Andrew Morton Subject: Re: [PATCH 2/2] Subject: printk: Don't trap random context in infinite log_buf flush Message-ID: <20171108112007.20c1e588@gandalf.local.home> In-Reply-To: <20171107002254.GI3252168@devbig577.frc2.facebook.com> References: <20171102135146.GN3252168@devbig577.frc2.facebook.com> <20171102135258.GO3252168@devbig577.frc2.facebook.com> <20171104042408.GB539@tigerII.localdomain> <20171107002254.GI3252168@devbig577.frc2.facebook.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Nov 2017 16:22:54 -0800 Tejun Heo wrote: > Hello, > > On Sat, Nov 04, 2017 at 01:24:08PM +0900, Sergey Senozhatsky wrote: > > thanks for the patch set. we are currently looking at another approach: > > lkml.kernel.org/r/20171102134515.6eef16de@gandalf.local.home > > > > would you be interested in taking a look? > > Hmm... It took some tweaking but the code at the end locks up the > machine w/ Steven's patch applied and it's not that contrived a case > (e.g. out of memory messages from packet tx/rx paths while OOM is in > progress). Did you apply it with or without the while (READ_ONCE(console_waiter)) fix? Because that is crucial. -- Steve