From: Steven Rostedt <rostedt@goodmis.org>
To: Tejun Heo <tj@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, kernel-team@fb.com,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] Subject: printk: Don't trap random context in infinite log_buf flush
Date: Wed, 8 Nov 2017 11:22:29 -0500 [thread overview]
Message-ID: <20171108112229.200858cb@gandalf.local.home> (raw)
In-Reply-To: <20171107132331.GJ3252168@devbig577.frc2.facebook.com>
On Tue, 7 Nov 2017 05:23:50 -0800
Tejun Heo <tj@kernel.org> wrote:
> Hello, Sergey.
>
> On Tue, Nov 07, 2017 at 11:04:34AM +0900, Sergey Senozhatsky wrote:
> > just to make sure. there is a typo in Steven's patch:
> >
> > while (!READ_ONCE(console_waiter))
> >
> > should be
> >
> > while (READ_ONCE(console_waiter))
> >
> > is this the "tweaking" you are talking about?
>
> Oh, I was talking about tweaking the repro, but I'm not sure the above
> would change anything.
No, it would change an awful lot.
It would cause two printers to access the consoles at the same time,
which would lead to unpredictable behavior.
-- Steve
next prev parent reply other threads:[~2017-11-08 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 13:51 [PATCH 1/2] printk: Relocate wake_klogd check close to the end of console_unlock() Tejun Heo
2017-11-02 13:52 ` [PATCH 2/2] Subject: printk: Don't trap random context in infinite log_buf flush Tejun Heo
2017-11-02 14:51 ` [PATCH TRIVIAL UPDATE 2/2] " Tejun Heo
2017-11-04 4:24 ` [PATCH 2/2] Subject: " Sergey Senozhatsky
2017-11-07 0:22 ` Tejun Heo
2017-11-07 2:04 ` Sergey Senozhatsky
2017-11-07 13:23 ` Tejun Heo
2017-11-08 5:29 ` Sergey Senozhatsky
2017-11-08 14:33 ` Tejun Heo
2017-11-08 16:22 ` Steven Rostedt [this message]
2017-11-08 16:28 ` Tejun Heo
2017-11-08 16:20 ` Steven Rostedt
2017-11-07 4:40 ` [PATCH 1/2] printk: Relocate wake_klogd check close to the end of console_unlock() Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108112229.200858cb@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®