From: Patrick Bellasi <patrick.bellasi@arm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: hpa@zytor.com, vincent.guittot@linaro.org, juri.lelli@redhat.com,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
peterz@infradead.org, brendan.jackman@arm.com,
torvalds@linux-foundation.org, chris.redpath@arm.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/core: Optimize sched_feat() for !SCHED_DEBUG builds
Date: Wed, 8 Nov 2017 11:24:50 +0000 [thread overview]
Message-ID: <20171108112450.GB31247@e110439-lin> (raw)
In-Reply-To: <20171108110252.GA31247@e110439-lin>
On 08-Nov 11:02, Patrick Bellasi wrote:
> On 08-Nov 11:03, Ingo Molnar wrote:
> >
> > * tip-bot for Patrick Bellasi <tipbot@zytor.com> wrote:
> >
> > > Commit-ID: 692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Gitweb: https://git.kernel.org/tip/692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Author: Patrick Bellasi <patrick.bellasi@arm.com>
> > > AuthorDate: Tue, 7 Nov 2017 16:06:58 +0000
> > > Committer: Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Wed, 8 Nov 2017 10:17:29 +0100
> > >
> > > sched/core: Optimize sched_feat() for !SCHED_DEBUG builds
> >
> > Hm, I noticed this too late, but lots of architecture defconfig builds now produce
> > a ton of warnings:
> >
> > In file included from /home/mingo/tip/kernel/sched/idle.c:19:0:
> > /home/mingo/tip/kernel/sched/sched.h:1275:33: warning: 'sysctl_sched_features' defined but not used [-Wunused-variable]
> > static const_debug unsigned int sysctl_sched_features =
> > ^
Perhaps just using a "__maybe_unused" attribute should fix the problem.
Going to compile test with some more archs, can you tell me a
defconfig failing for you?
> > I'm dropping this patch for now.
>
> Ok Ingo, thanks.
> Actually, my fault I did not checked archs other then arm64 and x86_64.
> I'll look into this and respin a clean new version.
>
> > Thanks,
> >
> > Ingo
>
> Cheers Patrick
>
> --
> #include <best/regards.h>
>
> Patrick Bellasi
--
#include <best/regards.h>
Patrick Bellasi
next prev parent reply other threads:[~2017-11-08 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 16:06 [PATCH] sched: fix sched_feat " Patrick Bellasi
2017-11-07 19:05 ` Peter Zijlstra
2017-11-08 9:46 ` [tip:sched/core] sched/core: Optimize sched_feat() " tip-bot for Patrick Bellasi
2017-11-08 10:03 ` Ingo Molnar
2017-11-08 11:02 ` Patrick Bellasi
2017-11-08 11:24 ` Patrick Bellasi [this message]
2017-11-08 13:05 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108112450.GB31247@e110439-lin \
--to=patrick.bellasi@arm.com \
--cc=brendan.jackman@arm.com \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®