From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752591AbdKHNFH (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Nov 2017 08:05:07 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:48925 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752076AbdKHNFF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Nov 2017 08:05:05 -0500
X-Google-Smtp-Source: ABhQp+TEcXt6l/NBUFTdpJ5sU7yKXd7bEIHr2JGHU39XIhIT5nBPmjle+KIgk7beiQOl6cDhlFFmXA==
Date: Wed, 8 Nov 2017 14:05:01 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: hpa@zytor.com, vincent.guittot@linaro.org, juri.lelli@redhat.com,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
        peterz@infradead.org, brendan.jackman@arm.com,
        torvalds@linux-foundation.org, chris.redpath@arm.com,
        linux-tip-commits@vger.kernel.org
Subject: Re: [tip:sched/core] sched/core: Optimize sched_feat() for
 !SCHED_DEBUG builds
Message-ID: <20171108130501.ichjfrmq4r5yrqmq@gmail.com>
References: <20171107160658.4839-1-patrick.bellasi@arm.com>
 <tip-692ee9a79c14c9f707eeb03754a26b9427c0e005@git.kernel.org>
 <20171108100308.ma73opbqgrlnxz74@gmail.com>
 <20171108110252.GA31247@e110439-lin>
 <20171108112450.GB31247@e110439-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171108112450.GB31247@e110439-lin>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Patrick Bellasi <patrick.bellasi@arm.com> wrote:

> On 08-Nov 11:02, Patrick Bellasi wrote:
> > On 08-Nov 11:03, Ingo Molnar wrote:
> > > 
> > > * tip-bot for Patrick Bellasi <tipbot@zytor.com> wrote:
> > > 
> > > > Commit-ID:  692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > > Gitweb:     https://git.kernel.org/tip/692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > > Author:     Patrick Bellasi <patrick.bellasi@arm.com>
> > > > AuthorDate: Tue, 7 Nov 2017 16:06:58 +0000
> > > > Committer:  Ingo Molnar <mingo@kernel.org>
> > > > CommitDate: Wed, 8 Nov 2017 10:17:29 +0100
> > > > 
> > > > sched/core: Optimize sched_feat() for !SCHED_DEBUG builds
> > > 
> > > Hm, I noticed this too late, but lots of architecture defconfig builds now produce 
> > > a ton of warnings:
> > > 
> > >  In file included from /home/mingo/tip/kernel/sched/idle.c:19:0:
> > >  /home/mingo/tip/kernel/sched/sched.h:1275:33: warning: 'sysctl_sched_features' defined but not used [-Wunused-variable]
> > >   static const_debug unsigned int sysctl_sched_features =
> > >                                   ^
> 
> Perhaps just using a "__maybe_unused" attribute should fix the problem.

Yeah, that would be OK in this case.

> Going to compile test with some more archs, can you tell me a
> defconfig failing for you?

Alpha was one of them - don't have the logs of the other warnings anymore.

Thanks,

	Ingo