From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbdKHQ5h convert rfc822-to-8bit (ORCPT ); Wed, 8 Nov 2017 11:57:37 -0500 Received: from terminus.zytor.com ([65.50.211.136]:44877 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbdKHQ5g (ORCPT ); Wed, 8 Nov 2017 11:57:36 -0500 From: "H. Peter Anvin" Message-Id: <201711081638.vA8GcSMV026939@mail.zytor.com> Date: Wed, 08 Nov 2017 08:38:18 -0800 User-Agent: K-9 Mail for Android In-Reply-To: References: <1509935277-22138-8-git-send-email-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions To: Linus Torvalds , Denys Vlasenko CC: Paolo Bonzini , Borislav Petkov , Vlastimil Babka , Tony Luck , Fenghua Yu , Josh Poimboeuf , Borislav Petkov , Brian Gerst , Jonathan Corbet , "Ravi V. Shankar" , ricardo.neri-calderon@linux.intel.com, Chris Metcalf , Andrew Morton , Paul Gortmaker , Masami Hiramatsu , Andrew Lutomirski , Dave Hansen , ray.huang@amd.com, "Michael S. Tsirkin" , Linux Kernel Mailing List , Peter Zijlstra , Chen Yucong , Ingo Molnar , Jiri Slaby , Shuah Khan , Thomas Gleixner , "linux-tip-commits@vger.kernel.org"@zytor.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: hpa@zytor.com Message-ID: <67A3DB9F-E58D-42B3-BF16-AC59D2FCECC2@zytor.com> On November 8, 2017 8:34:45 AM PST, Linus Torvalds wrote: >On Wed, Nov 8, 2017 at 8:14 AM, Denys Vlasenko >wrote: >> >> Can we avoid maintain emulation of these isns, by asking Wine to >remove >> their use instead? > >If we ask the Wine people to remove the instruction use, that may mean >that we can avoid the emulation in four or five _years_ once everybody >has updated. > >But it wouldn't mean that we could avoid it today. > >We *do* probably want to print a warning about these instructions, >whether emulated or not. If emulated, we want to print a warning about >the emulation being expensive (as a nudge to the Wine people to not do >that), and if _not_ emulated, we'd want to print a warning about why >people suddenly got a SIGSEGV in case there are programs that use >those instructions that people didn't even think of. > >But make it ratelimit the warning (perhaps at most once every few >minutes or whatever), so that people won't flood message logs just >because they have old stupid programs that use those things. > > Linus The real problem is that 16-bit software uses the instructions mostly for stupid reasons, but smsw in particular is used exactly because it is a virtualization hole. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.