From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbdKHReY (ORCPT ); Wed, 8 Nov 2017 12:34:24 -0500 Received: from www.llwyncelyn.cymru ([82.70.14.225]:49734 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbdKHReW (ORCPT ); Wed, 8 Nov 2017 12:34:22 -0500 Date: Wed, 8 Nov 2017 17:34:14 +0000 From: Alan Cox To: "Ji-Ze Hong (Peter Hong)" Cc: gregkh@linuxfoundation.org, jslaby@suse.com, lukas@wunner.de, rel+kernel@agilox.net, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, ricardo.ribalda@gmail.com, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0 Message-ID: <20171108173414.7b16c796@alans-desktop> In-Reply-To: <1510110346-28893-1-git-send-email-hpeter+linux_kernel@gmail.com> References: <1510110346-28893-1-git-send-email-hpeter+linux_kernel@gmail.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Nov 2017 11:05:46 +0800 "Ji-Ze Hong (Peter Hong)" wrote: > The 8250_fintek.c is support the Fintek F81866/F81216 with dynamic clock. > But It'll generate "division by zero" exception and crash in > fintek_8250_set_termios() with baud rate 0 on baudrate_table[i] % baud. 0 means "hang up", so this looks good providing it leaves the device in a sane state. Reviewed-by: Alan Cox