From: Christoph Hellwig <hch@infradead.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Sam Ravnborg <sam@ravnborg.org>,
sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] sparc: pass endianness info to sparse
Date: Thu, 9 Nov 2017 00:34:52 -0800 [thread overview]
Message-ID: <20171109083452.GA10787@infradead.org> (raw)
In-Reply-To: <20171109061652.14948-3-luc.vanoostenryck@gmail.com>
On Thu, Nov 09, 2017 at 07:16:52AM +0100, Luc Van Oostenryck wrote:
> sparc is big-endian only but sparse assumes the same endianness
> as the building machine.
> This is problematic for code which expect __BYTE_ORDER__ being
> correctly predefined by the compiler which sparse can then
> pre-process differently from what gcc would, depending on the
> building machine endianness.
>
> Fix this by letting sparse know about the architecture endianness.
You're posted patches for this for about half a dozen architectures
now, but we also now have generic Kconfig symbols for the byte order.
I'd much rather see this done in generic code than hacking it up
everywhere.
next prev parent reply other threads:[~2017-11-09 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 6:16 [PATCH v2 0/2] " Luc Van Oostenryck
2017-11-09 6:16 ` [PATCH v2 1/2] sparc: use a common CHECKFLAGS entry for common flags Luc Van Oostenryck
2017-11-09 6:16 ` [PATCH v2 2/2] sparc: pass endianness info to sparse Luc Van Oostenryck
2017-11-09 8:34 ` Christoph Hellwig [this message]
2017-11-09 13:13 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109083452.GA10787@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®