From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753639AbdKII4B (ORCPT ); Thu, 9 Nov 2017 03:56:01 -0500 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:9270 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbdKIIz6 (ORCPT ); Thu, 9 Nov 2017 03:55:58 -0500 X-IronPort-AV: E=Sophos;i="5.44,368,1505779200"; d="scan'208";a="700965368" Date: Thu, 9 Nov 2017 00:55:47 -0800 From: Eduardo Valentin To: Radim =?utf-8?B?S3LEjW3DocWZ?= CC: Eduardo Valentin , Paolo Bonzini , Matt Wilson , Jonathan Corbet , "Thomas Gleixner" , Ingo Molnar , "H. Peter Anvin" , , Peter Zijlstra , Waiman Long , , , , "Jan H . Schoenherr" , Anthony Liguori Subject: Re: [PATCHv3 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set Message-ID: <20171109085547.GA5107@u40b0340c692b58f6553c.ant.amazon.com> References: <1509999980-10828-1-git-send-email-eduval@amazon.com> <20171108173651.GA3664@flask> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171108173651.GA3664@flask> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Nov 08, 2017 at 06:36:52PM +0100, Radim Krčmář wrote: > 2017-11-06 12:26-0800, Eduardo Valentin: > > Currently, the existing qspinlock implementation will fallback to > > test-and-set if the hypervisor has not set the PV_UNHALT flag. > > > > This patch gives the opportunity to guest kernels to select > > between test-and-set and the regular queueu fair lock implementation > > based on the PV_DEDICATED KVM feature flag. When the PV_DEDICATED > > flag is not set, the code will still fall back to test-and-set, > > but when the PV_DEDICATED flag is set, the code will use > > the regular queue spinlock implementation. > > > > With this patch, when in autoselect mode, the guest will > > use the default spinlock implementation based on host feature > > flags as follows: > > > > PV_DEDICATED = 1, PV_UNHALT = anything: default is qspinlock > > PV_DEDICATED = 0, PV_UNHALT = 1: default is pvqspinlock > > PV_DEDICATED = 0, PV_UNHALT = 0: default is tas > > > > Cc: Paolo Bonzini > > Cc: "Radim Krčmář" > > Cc: Jonathan Corbet > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: "H. Peter Anvin" > > Cc: x86@kernel.org > > Cc: Peter Zijlstra > > Cc: Waiman Long > > Cc: kvm@vger.kernel.org > > Cc: linux-doc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: Jan H. Schoenherr > > Cc: Anthony Liguori > > Suggested-by: Matt Wilson > > Signed-off-by: Eduardo Valentin > > --- > > V3: > > - When PV_DEDICATED is set (1), qspinlock is selected, > > regardless of the value of PV_UNHAULT. Suggested by Paolo Bonzini. > > - Refreshed on top of tip/master. > > V2: > > - rebase on top of tip/master > > > > Documentation/virtual/kvm/cpuid.txt | 6 ++++++ > > arch/x86/include/asm/qspinlock.h | 4 ++++ > > arch/x86/include/uapi/asm/kvm_para.h | 1 + > > arch/x86/kernel/kvm.c | 2 ++ > > 4 files changed, 13 insertions(+) > > > > diff --git a/Documentation/virtual/kvm/cpuid.txt b/Documentation/virtual/kvm/cpuid.txt > > index 3c65feb..117066a 100644 > > --- a/Documentation/virtual/kvm/cpuid.txt > > +++ b/Documentation/virtual/kvm/cpuid.txt > > @@ -54,6 +54,12 @@ KVM_FEATURE_PV_UNHALT || 7 || guest checks this feature bit > > || || before enabling paravirtualized > > || || spinlock support. > > ------------------------------------------------------------------------------ > > +KVM_FEATURE_PV_DEDICATED || 8 || guest checks this feature bit > > + || || to determine if they run on > > + || || dedicated vCPUs, allowing opti- > > + || || mizations such as usage of > > + || || qspinlocks. > > +------------------------------------------------------------------------------ > > KVM_FEATURE_CLOCKSOURCE_STABLE_BIT || 24 || host will warn if no guest-side > > || || per-cpu warps are expected in > > || || kvmclock. > > diff --git a/arch/x86/include/asm/qspinlock.h b/arch/x86/include/asm/qspinlock.h > > index 5e16b5d..de42694 100644 > > --- a/arch/x86/include/asm/qspinlock.h > > +++ b/arch/x86/include/asm/qspinlock.h > > @@ -3,6 +3,8 @@ > > #define _ASM_X86_QSPINLOCK_H > > > > #include > > +#include > > + > > #include > > #include > > #include > > @@ -58,6 +60,8 @@ static inline bool virt_spin_lock(struct qspinlock *lock) > > if (!static_branch_likely(&virt_spin_lock_key)) > > return false; > > > > + if (kvm_para_has_feature(KVM_FEATURE_PV_DEDICATED)) > > + return false; > > Hm, every spinlock slowpath calls cpuid, which causes a VM exit, so I > wouldn't expect it to be faster than the existing implementations. > (Using the static key would be better.) > > How does this patch perform compared to user-forced qspinlock and hybrid > pvqspinlock? This patch should have same effect as user-forced qspinlock. However, the key aspect here is this patch gives a way for the host to instruct the guest to use qspinlock. Even with Longman's patch which allows guest to select the spinlock implementation, there should still be the auto-select mode. In such mode, PV_DEDICATED should allow the host to get the guest to use qspinlock, without, the guest will fallback to tas when PV_UNHALT == 0. > > Thanks. > -- All the best, Eduardo Valentin