From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754225AbdKIMHs (ORCPT ); Thu, 9 Nov 2017 07:07:48 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:55045 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754180AbdKIMHp (ORCPT ); Thu, 9 Nov 2017 07:07:45 -0500 X-Google-Smtp-Source: ABhQp+Q3sr2/qfiWOGUf54A9zVgDGODdU3N1+xvJxZtAhnjSpOXOHcu298yge8s4kAJozNK8cdNeOQ== Date: Thu, 9 Nov 2017 13:07:42 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Mario Limonciello Cc: dvhart@infradead.org, Andy Shevchenko , LKML , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 1/2] platform/x86: dell-wmi-descriptor: check if memory was allocated Message-ID: <20171109120742.6ctactdfgygdati3@pali> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 03 November 2017 11:27:21 Mario Limonciello wrote: > devm_kzalloc will return NULL pointer if no memory was allocated. > This should be checked. This problem also existed when the driver > was dell-wmi.c. > > Signed-off-by: Mario Limonciello Reviewed-by: Pali Rohár > --- > drivers/platform/x86/dell-wmi-descriptor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/platform/x86/dell-wmi-descriptor.c b/drivers/platform/x86/dell-wmi-descriptor.c > index 3204c408e261..28ef5f37cfbf 100644 > --- a/drivers/platform/x86/dell-wmi-descriptor.c > +++ b/drivers/platform/x86/dell-wmi-descriptor.c > @@ -121,6 +121,11 @@ static int dell_wmi_descriptor_probe(struct wmi_device *wdev) > priv = devm_kzalloc(&wdev->dev, sizeof(struct descriptor_priv), > GFP_KERNEL); > > + if (!priv) { > + ret = -ENOMEM; > + goto out; > + } > + > priv->interface_version = buffer[2]; > priv->size = buffer[3]; > ret = 0; -- Pali Rohár pali.rohar@gmail.com