From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752625AbdKIRUB (ORCPT ); Thu, 9 Nov 2017 12:20:01 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:58942 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbdKIRUA (ORCPT ); Thu, 9 Nov 2017 12:20:00 -0500 From: Colin King To: Greg Kroah-Hartman , Marcus Wolf , Al Viro , devel@driverdev.osuosl.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: pi433: fix missing break in switch statement. Date: Thu, 9 Nov 2017 17:19:55 +0000 Message-Id: <20171109171955.10911-1-colin.king@canonical.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The PI433_IOC_WR_RX_CFG case is missing a break and will fall through to the default case and errorenously return -EINVAL. Fix this by adding in missing break. Detected by CoverityScan, CID#1461286 ("Missing break in switch") Fixes: f81f0b5c9a30 ("pi433: sanitize ioctl") Signed-off-by: Colin Ian King --- drivers/staging/pi433/pi433_if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index 3bcb59811cdf..a960fe2e7875 100644 --- a/drivers/staging/pi433/pi433_if.c +++ b/drivers/staging/pi433/pi433_if.c @@ -811,6 +811,7 @@ pi433_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) } mutex_unlock(&device->rx_lock); + break; default: retval = -EINVAL; } -- 2.14.1