From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753523AbdKISTK (ORCPT ); Thu, 9 Nov 2017 13:19:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:51868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751201AbdKISTI (ORCPT ); Thu, 9 Nov 2017 13:19:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC556214EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jaegeuk@kernel.org Date: Thu, 9 Nov 2017 10:19:05 -0800 From: Jaegeuk Kim To: Chao Yu Cc: Hyunchul Lee , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@lge.com, Hyunchul Lee Subject: Re: [RFC PATHC 1/2] f2fs: apply write hints to select the type of segments for buffered write Message-ID: <20171109181905.GB59398@jaegeuk-macbookpro.roam.corp.google.com> References: <1510206688-12767-1-git-send-email-hyc.lee@gmail.com> <1510206688-12767-2-git-send-email-hyc.lee@gmail.com> <89790335-1d07-9280-ef17-1bdaeaafb54b@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89790335-1d07-9280-ef17-1bdaeaafb54b@huawei.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09, Chao Yu wrote: > On 2017/11/9 13:51, Hyunchul Lee wrote: > > From: Hyunchul Lee > > > > Write hints helps F2FS to determine which type of segments would be > > selected for buffered write. > > > > This patch implements the mapping from write hints to segment types > > as shown below. > > > > hints segment type > > ----- ------------ > > WRITE_LIFE_SHORT CURSEG_COLD_DATA > > WRITE_LIFE_EXTREME CURSEG_HOT_DATA > > Should keep consistent with code implementation. Merged with this fix. ;) > > WRITE_LIFE_SHORT CURSEG_HOT_DATA > WRITE_LIFE_EXTREME CURSEG_COLD_DATA > > > others CURSEG_WARM_DATA > > > > the F2FS poliy for hot/cold seperation has precedence over this hints. > > And hints are not applied in in-place update. > > > > Signed-off-by: Hyunchul Lee > > Reviewed-by: Chao Yu > > Thanks, > > > --- > > fs/f2fs/segment.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > > index c695ff4..45aef53 100644 > > --- a/fs/f2fs/segment.c > > +++ b/fs/f2fs/segment.c > > @@ -2258,6 +2258,18 @@ static bool __has_curseg_space(struct f2fs_sb_info *sbi, int type) > > return false; > > } > > > > +int rw_hint_to_seg_type(enum rw_hint hint) > > +{ > > + switch (hint) { > > + case WRITE_LIFE_SHORT: > > + return CURSEG_HOT_DATA; > > + case WRITE_LIFE_EXTREME: > > + return CURSEG_COLD_DATA; > > + default: > > + return CURSEG_WARM_DATA; > > + } > > +} > > + > > static int __get_segment_type_2(struct f2fs_io_info *fio) > > { > > if (fio->type == DATA) > > @@ -2292,7 +2304,7 @@ static int __get_segment_type_6(struct f2fs_io_info *fio) > > return CURSEG_COLD_DATA; > > if (is_inode_flag_set(inode, FI_HOT_DATA)) > > return CURSEG_HOT_DATA; > > - return CURSEG_WARM_DATA; > > + return rw_hint_to_seg_type(inode->i_write_hint); > > } else { > > if (IS_DNODE(fio->page)) > > return is_cold_node(fio->page) ? CURSEG_WARM_NODE : > >