From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Marcus Wolf <linux@Wolf-Entwicklungen.de>,
Al Viro <viro@zeniv.linux.org.uk>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: fix missing break in switch statement.
Date: Fri, 10 Nov 2017 00:48:18 +0300 [thread overview]
Message-ID: <20171109214818.r4mcizwmnmhyvo26@mwanda> (raw)
In-Reply-To: <20171109171955.10911-1-colin.king@canonical.com>
On Thu, Nov 09, 2017 at 05:19:55PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The PI433_IOC_WR_RX_CFG case is missing a break and will fall through
> to the default case and errorenously return -EINVAL. Fix this by
> adding in missing break.
>
Could you fix PI433_IOC_RD_RX_CFG as well? There is a missing return
statement if the copy_to_user() fails we fall through to here and error
out.
regards,
dan carpenter
next prev parent reply other threads:[~2017-11-09 21:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 17:19 Colin King
2017-11-09 18:34 ` Al Viro
2017-11-09 21:48 ` Dan Carpenter [this message]
2017-11-10 16:49 ` Marcus Wolf
2017-11-10 17:04 ` Colin Ian King
2017-11-10 17:14 ` Marcus Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171109214818.r4mcizwmnmhyvo26@mwanda \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®