mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shankara Pailoor <sp3485@columbia.edu>,
	Michael Kerrisk <mtk.manpages@gmail.com>
Subject: Re: [RFC PATCH] fs/pipe.c: implement minimum pipe size for arg==0
Date: Thu, 9 Nov 2017 16:21:17 -0600	[thread overview]
Message-ID: <20171109222117.st6hnkzw6hsn462w@treble> (raw)
In-Reply-To: <6f9f4e86-9102-a8a1-7c6a-8586f47be044@infradead.org>

On Thu, Nov 09, 2017 at 02:09:03PM -0800, Randy Dunlap wrote:
> > Searching through lkml, it looks like there have been four attempts to
> > fix this issue in the last year or so, but none of them have been
> > merged.  It would be nice to finally get a fix in.
> > 
> > I agree with the patch, though I would argue that the fix belongs in
> > round_pipe_size() so that other callers don't get the same bug.
> 
> Hi Josh,
> 
> Yes, I debated with myself on where to put the patch. I made it more local
> instead of global just to have less accidental impact.
> 
> 
> Andrew has these 4 patches from Joe Lawrence in mmotm:
> 
> pipe-add-proc_dopipe_max_size-to-safely-assign-pipe_max_size.patch
> pipe-avoid-round_pipe_size-nr_pages-overflow-on-32-bit.patch
> pipe-match-pipe_max_size-data-type-with-procfs.patch
> sysctl-check-for-uint_max-before-unsigned-int-min-max.patch
> 
> 
> Hopefully they can be merged soon.
> I blame people who travel a lot.  ;)

Ah, I missed Joe's patches (and neglected to check linux-next).  Thanks!

-- 
Josh

      reply	other threads:[~2017-11-09 22:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-11 23:15 Randy Dunlap
2017-11-09 21:45 ` Josh Poimboeuf
2017-11-09 22:09   ` Randy Dunlap
2017-11-09 22:21     ` Josh Poimboeuf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171109222117.st6hnkzw6hsn462w@treble \
    --to=jpoimboe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=sp3485@columbia.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®