From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755105AbdKIWYH (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Nov 2017 17:24:07 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:51363 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753012AbdKIWYF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Nov 2017 17:24:05 -0500
Date: Thu, 9 Nov 2017 23:23:52 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: David Daney <david.daney@cavium.com>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
        James Hogan <james.hogan@mips.com>, netdev@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org,
        "Steven J. Hill" <steven.hill@cavium.com>, devicetree@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Carlos Munoz <cmunoz@cavium.com>
Subject: Re: [PATCH v3 7/8] netdev: octeon-ethernet: Add Cavium Octeon III
 support.
Message-ID: <20171109222352.GA25275@lunn.ch>
References: <20171109192915.11912-1-david.daney@cavium.com>
 <20171109192915.11912-8-david.daney@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171109192915.11912-8-david.daney@cavium.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +	priv->phy_np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
> +	priv->phy_mode = of_get_phy_mode(pdev->dev.of_node);
> +	/* If phy-mode absent, default to SGMII. */
> +	if (priv->phy_mode < 0)
> +		priv->phy_mode = PHY_INTERFACE_MODE_SGMII;
> +
> +	if (priv->phy_mode == PHY_INTERFACE_MODE_1000BASEX)
> +		priv->mode_1000basex = true;
> +
> +	if (of_phy_is_fixed_link(pdev->dev.of_node))
> +		priv->bgx_as_phy = true;
> +

...

> +	priv->mode = bgx_port_get_mode(priv->node, priv->bgx, priv->index);
> +

It might be a good idea to verify priv->phy_mode and priv->mode are
compatible.

> +	switch (priv->mode) {
> +	case PORT_MODE_SGMII:
> +	case PORT_MODE_RGMII:
> +		priv->get_link = bgx_port_get_sgmii_link;
> +		priv->set_link = bgx_port_set_xgmii_link;
> +		break;
> +	case PORT_MODE_XAUI:
> +	case PORT_MODE_RXAUI:
> +	case PORT_MODE_XLAUI:
> +	case PORT_MODE_XFI:
> +	case PORT_MODE_10G_KR:
> +	case PORT_MODE_40G_KR4:
> +		priv->get_link = bgx_port_get_xaui_link;
> +		priv->set_link = bgx_port_set_xaui_link;
> +		break;


  Andrew