From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753141AbdKJPHF convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Nov 2017 10:07:05 -0500
Received: from mail.kernel.org ([198.145.29.99]:37744 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750978AbdKJPHE (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Nov 2017 10:07:04 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2A5D218EB
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Fri, 10 Nov 2017 10:07:00 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: David Miller <davem@davemloft.net>, Song Liu <songliubraving@fb.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: Export to userspace the TCP state names for the
 trace events
Message-ID: <20171110100700.5870c21f@gandalf.local.home>
In-Reply-To: <CALOAHbCM1d8rs1_KMo0MMCwgTG18TeiH_ZQJ2=sgPst2PoU9Xg@mail.gmail.com>
References: <1510207298-14828-1-git-send-email-laoar.shao@gmail.com>
        <20171109064326.skfvvohg7qhgl3lp@ast-mbp>
        <20171109131808.373c296f@gandalf.local.home>
        <30A95900-7378-439F-954E-BD5487012435@fb.com>
        <CFF85160-E239-4E15-8438-CB8C2795D4FD@fb.com>
        <20171109195712.47fe23b6@gandalf.local.home>
        <CALOAHbCM1d8rs1_KMo0MMCwgTG18TeiH_ZQJ2=sgPst2PoU9Xg@mail.gmail.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 10 Nov 2017 12:56:06 +0800
Yafang Shao <laoar.shao@gmail.com> wrote:

> Could the macro tcp_state_name() be renamed ？
> If <trace/events/tcp.h> is included in include/net/tcp.h, it will

Ideally, you don't want to include trace/events/*.h headers in other
headers, as they can have side effects if those headers are included in
other trace/events/*.h headers.

> cause compile error, because there's another function tcp_state_name()
> defined in net/netfilter/ipvs/ip_vs_proto_tcp.c.
>     static const char * tcp_state_name(int state)
>     {
> 
>         if (state >= IP_VS_TCP_S_LAST)
> 
>             return "ERR!";
> 
>         return tcp_state_name_table[state] ? tcp_state_name_table[state] : "?";
> 
>     }

But that said, I didn't make up the trace_state_name(), it was already
there in net-next before this patch.

But yeah, in actuality, I would have just done:

#define EM(a)	{ a, #a },
#define EMe(a)	{ a, #a }

directly. Which we can still do.

-- Steve