From: Peter Zijlstra <peterz@infradead.org>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Radim Kr??m???? <rkrcmar@redhat.com>,
Wanpeng Li <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v3 4/4] KVM: Add flush_on_enter before guest enter
Date: Fri, 10 Nov 2017 11:08:38 +0100 [thread overview]
Message-ID: <20171110100838.eqfccs735x4ghw6q@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1510307387-14812-5-git-send-email-wanpeng.li@hotmail.com>
On Fri, Nov 10, 2017 at 01:49:47AM -0800, Wanpeng Li wrote:
> @@ -2887,7 +2899,7 @@ static void kvm_steal_time_set_preempted(struct kvm_vcpu *vcpu)
> if (!(vcpu->arch.st.msr_val & KVM_MSR_ENABLED))
> return;
>
> - vcpu->arch.st.steal.preempted = KVM_VCPU_PREEMPTED;
> + vcpu->arch.st.steal.preempted |= KVM_VCPU_PREEMPTED;
I don't understand this one... If there is concurrency its wrong, if
there is no concurrency it still doesn't make sense as there should not
be any FLUSH flags to preserve..
>
> kvm_write_guest_offset_cached(vcpu->kvm, &vcpu->arch.st.stime,
> &vcpu->arch.st.steal.preempted,
next prev parent reply other threads:[~2017-11-10 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 9:49 [PATCH v3 0/4] KVM: Paravirt remote TLB flush Wanpeng Li
2017-11-10 9:49 ` [PATCH v3 1/4] KVM: Add vCPU running/preempted state Wanpeng Li
2017-11-10 9:49 ` [PATCH v3 2/4] KVM: Add paravirt remote TLB flush Wanpeng Li
2017-11-10 10:06 ` Peter Zijlstra
2017-11-10 9:49 ` [PATCH v3 3/4] KVM: X86: introduce invalidate_gpa argument to tlb flush Wanpeng Li
2017-11-10 9:49 ` [PATCH v3 4/4] KVM: Add flush_on_enter before guest enter Wanpeng Li
2017-11-10 10:07 ` Peter Zijlstra
2017-11-13 0:38 ` Wanpeng Li
2017-11-10 10:08 ` Peter Zijlstra [this message]
2017-11-10 10:15 ` Paolo Bonzini
2017-11-10 10:31 ` Peter Zijlstra
2017-11-10 16:49 ` Paolo Bonzini
2017-11-10 12:43 ` [PATCH v3 0/4] KVM: Paravirt remote TLB flush David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110100838.eqfccs735x4ghw6q@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®