From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753175AbdKJP3A (ORCPT ); Fri, 10 Nov 2017 10:29:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:39366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752448AbdKJP27 (ORCPT ); Fri, 10 Nov 2017 10:28:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BE11214EE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 10 Nov 2017 10:28:56 -0500 From: Steven Rostedt To: "Yordan Karadzhov (VMware)" Cc: jan.kiszka@siemens.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] kernelshark: Adding gui_event_handlers for View and Graph Message-ID: <20171110102856.5f77ef26@gandalf.local.home> In-Reply-To: <20171110122915.24929-3-y.karadz@gmail.com> References: <20171110122915.24929-1-y.karadz@gmail.com> <20171110122915.24929-3-y.karadz@gmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Nov 2017 14:29:14 +0200 "Yordan Karadzhov (VMware)" wrote: > +void trace_graph_register_gui_handler(struct graph_info *info, > + struct gui_event_handler *handler) { > + handler->next = info->event_handlers; > + info->event_handlers = handler; > +} > + > > +void trace_view_store_register_gui_handler(TraceViewStore *store, struct gui_event_handler *handler) > +{ > + handler->next = store->event_handlers; > + store->event_handlers = handler; > +} > + Hmm, and in the last patch we have: + trace_view_store_register_gui_handler(ks_store, switch_handler); + trace_view_store_register_gui_handler(ks_store, wakeup_handler); + + trace_graph_register_gui_handler(ks_info->ginfo, switch_handler); + trace_graph_register_gui_handler(ks_info->ginfo, wakeup_handler); I think I see an issue here. ;-) (Hint, what's the state of switch_handler->next and wakeup_handler->next, when this is done?) -- Steve