From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751664AbdKJMUr (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Nov 2017 07:20:47 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:50203 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750835AbdKJMUq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Nov 2017 07:20:46 -0500
Date: Fri, 10 Nov 2017 13:20:30 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        moritz.lipp@iaik.tugraz.at, daniel.gruss@iaik.tugraz.at,
        michael.schwarz@iaik.tugraz.at, richard.fellner@student.tugraz.at,
        luto@kernel.org, torvalds@linux-foundation.org, keescook@google.com,
        hughd@google.com, x86@kernel.org
Subject: Re: [PATCH 20/30] x86, mm: remove hard-coded ASID limit checks
Message-ID: <20171110122030.5zyplbb3tnwpa2vu@hirez.programming.kicks-ass.net>
References: <20171108194646.907A1942@viggo.jf.intel.com>
 <20171108194724.C0167D83@viggo.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171108194724.C0167D83@viggo.jf.intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 08, 2017 at 11:47:24AM -0800, Dave Hansen wrote:
> +#define CR3_HW_ASID_BITS 12
> +#define NR_AVAIL_ASIDS ((1<<CR3_AVAIL_ASID_BITS) - 1)

That evaluates to 4095

> -		VM_WARN_ON_ONCE(asid > 4094);
> +		VM_WARN_ON_ONCE(asid > NR_AVAIL_ASIDS);

Not the same number