From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753743AbdKJSYk (ORCPT ); Fri, 10 Nov 2017 13:24:40 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:56936 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753715AbdKJSYh (ORCPT ); Fri, 10 Nov 2017 13:24:37 -0500 X-Google-Smtp-Source: AGs4zMaBVk3agnrAqvHRTWjdHzGWK/4GzkprEg69tK0wEI4m2E9AytpOycgJlrpFYVANXqBRbKMojA== Date: Fri, 10 Nov 2017 10:24:34 -0800 From: Dmitry Torokhov To: "Gustavo A. R. Silva" Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: gamecon - mark expected switch fall-throughs Message-ID: <20171110182434.j2jlplhaaa3r4oh2@dtor-ws> References: <20171109030712.GA14989@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171109030712.GA14989@embeddedor.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 09:07:12PM -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 114761 > Addresses-Coverity-ID: 114762 > Signed-off-by: Gustavo A. R. Silva Applied, thank you. > --- > drivers/input/joystick/gamecon.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c > index c43f087..ca734ea 100644 > --- a/drivers/input/joystick/gamecon.c > +++ b/drivers/input/joystick/gamecon.c > @@ -654,6 +654,7 @@ static void gc_psx_report_one(struct gc_pad *pad, unsigned char psx_type, > > input_report_key(dev, BTN_THUMBL, ~data[0] & 0x04); > input_report_key(dev, BTN_THUMBR, ~data[0] & 0x02); > + /* fall through */ > > case GC_PSX_NEGCON: > case GC_PSX_ANALOG: > @@ -887,6 +888,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type) > case GC_SNES: > for (i = 4; i < 8; i++) > __set_bit(gc_snes_btn[i], input_dev->keybit); > + /* fall through */ > case GC_NES: > for (i = 0; i < 4; i++) > __set_bit(gc_snes_btn[i], input_dev->keybit); > @@ -894,6 +896,7 @@ static int gc_setup_pad(struct gc *gc, int idx, int pad_type) > > case GC_MULTI2: > __set_bit(BTN_THUMB, input_dev->keybit); > + /* fall through */ > case GC_MULTI: > __set_bit(BTN_TRIGGER, input_dev->keybit); > break; > -- > 2.7.4 > -- Dmitry