From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbdKKK3y (ORCPT ); Sat, 11 Nov 2017 05:29:54 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46456 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751336AbdKKK3w (ORCPT ); Sat, 11 Nov 2017 05:29:52 -0500 Date: Sat, 11 Nov 2017 19:29:47 +0900 (KST) Message-Id: <20171111.192947.1434990343306413974.davem@davemloft.net> To: niklas.cassel@axis.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, Joao.Pinto@synopsys.com, niklass@axis.com, alexandre.torgue@st.com, peppe.cavallaro@st.com, treding@nvidia.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] bindings: net: stmmac: correctify note about LPI interrupt From: David Miller In-Reply-To: <20171109170928.15496-1-niklas.cassel@axis.com> References: <20171109170928.15496-1-niklas.cassel@axis.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 11 Nov 2017 02:29:51 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Niklas Cassel Date: Thu, 9 Nov 2017 18:09:26 +0100 > There are two different combined signal for various interrupt events: > In EQOS-CORE and EQOS-MTL configurations, mci_intr_o is the interrupt > signal. > In EQOS-DMA, EQOS-AHB and EQOS-AXI configurations, these interrupt events > are combined with the events in the DMA on the sbd_intr_o signal. > > Depending on configuration, the device tree irq "macirq" will refer to > either mci_intr_o or sbd_intr_o. > > The databook states: > "The MAC generates the LPI interrupt when the Tx or Rx side enters or exits > the LPI state. The interrupt mci_intr_o (sbd_intr_o in certain > configurations) is asserted when the LPI interrupt status is set. > > When the MAC exits the Rx LPI state, then in addition to the mci_intr_o > (sbd_intr_o in certain configurations), the sideband signal lpi_intr_o is > asserted. > > If you do not want to gate-off the application clock during the Rx LPI > state, you can leave the lpi_intr_o signal unconnected and use the > mci_intr_o (sbd_intr_o in certain configurations) signal to detect Rx LPI > exit." > > Since the "macirq" is always raised when Tx or Rx enters/exits the LPI > state, "eth_lpi" must therefore refer to lpi_intr_o, which is only raised > when Rx exits the LPI state. Update the DT binding description to reflect > reality. > > Signed-off-by: Niklas Cassel Applied.