From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbdKKAM7 (ORCPT ); Fri, 10 Nov 2017 19:12:59 -0500 Received: from [192.55.52.93] ([192.55.52.93]:65415 "EHLO mga11.intel.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754807AbdKKAMw (ORCPT ); Fri, 10 Nov 2017 19:12:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,377,1505804400"; d="scan'208";a="275080" Subject: [PATCH 4/4] x86, selftests: fix protection keys write() warining To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, Dave Hansen From: Dave Hansen Date: Fri, 10 Nov 2017 16:12:32 -0800 References: <20171111001226.810E7A73@viggo.jf.intel.com> In-Reply-To: <20171111001226.810E7A73@viggo.jf.intel.com> Message-Id: <20171111001232.94813E58@viggo.jf.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dave Hansen write() is marked as having a must-check return value. Check it and abort if we fail to write an error message from a signal handler. Signed-off-by: Dave Hansen --- b/tools/testing/selftests/x86/pkey-helpers.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff -puN tools/testing/selftests/x86/pkey-helpers.h~x86-selftests-protection-keys-write-warning tools/testing/selftests/x86/pkey-helpers.h --- a/tools/testing/selftests/x86/pkey-helpers.h~x86-selftests-protection-keys-write-warning 2017-11-10 15:29:29.240207938 -0800 +++ b/tools/testing/selftests/x86/pkey-helpers.h 2017-11-10 15:29:29.244207938 -0800 @@ -30,6 +30,7 @@ static inline void sigsafe_printf(const if (!dprint_in_signal) { vprintf(format, ap); } else { + int ret; int len = vsnprintf(dprint_in_signal_buffer, DPRINT_IN_SIGNAL_BUF_SIZE, format, ap); @@ -39,7 +40,9 @@ static inline void sigsafe_printf(const */ if (len > DPRINT_IN_SIGNAL_BUF_SIZE) len = DPRINT_IN_SIGNAL_BUF_SIZE; - write(1, dprint_in_signal_buffer, len); + ret = write(1, dprint_in_signal_buffer, len); + if (ret < 0) + abort(); } va_end(ap); } _