From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751404AbdKLNN5 (ORCPT ); Sun, 12 Nov 2017 08:13:57 -0500 Received: from SMTP.ANDREW.CMU.EDU ([128.2.105.203]:42077 "EHLO smtp.andrew.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbdKLNNt (ORCPT ); Sun, 12 Nov 2017 08:13:49 -0500 Date: Sun, 12 Nov 2017 07:40:03 -0500 From: "Gabriel L. Somlo" To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau Cc: linux-kernel@vger.kernel.org, somlo@cmu.edu, qemu-devel@nongnu.org, mst@redhat.com Subject: Re: [PATCH v4 0/5] fw_cfg: add DMA operations & etc/vmcoreinfo support Message-ID: <20171112124003.GA19857@hedwig.ini.cmu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171031151938.14982-1-marcandre.lureau@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.1 (2017-09-22) X-PMX-Version: 6.3.0.2556906, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.11.12.122717 X-SMTP-Spam-Clean: 8% ( MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, FROM_EDU_TLD 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_MSGID 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __NO_HTML_TAG_RAW 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_MAILTO 0, __URI_NO_WWW 0, __USER_AGENT 0) X-SMTP-Spam-Score: 8% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 31, 2017 at 04:19:33PM +0100, Marc-André Lureau wrote: > Hi, > > This series adds DMA operations support to the qemu fw_cfg kernel > module and populates "etc/vmcoreinfo" with vmcoreinfo location > details. > > Note: the support for this entry handling has been merged for next > qemu release (2.11) > > v4: > - export paddr_vmcoreinfo_note() to fix fw_cfg.ko build > - fix build with !CONFIG_CRASH_CORE > - replace the unbounded yield() loop with a usleep_range() loop and a > 200ms timeout > - do not write vmcoreinfo entry when running the kdump kernel (D. Hatayama) > - drop the experimental sysfs write support patch from this series Tested it on x86_64, appears to work fine. I have a couple of silly questions re. 3/5 and 5/5. Lost the v5 emails with the vmcore folks cc-ed, but my questions are unrelated to vmcore anyway :) Thanks, --Gabriel > > v3: (thanks kbuild) > - add "fw_cfg: fix the command line module name" patch > - fix build of "fw_cfg: add DMA register" with CONFIG_FW_CFG_SYSFS_CMDLINE=y > - fix 'Wshift-count-overflow' > > v2: > - use platform device for dma mapping > - add etc/vmcoreinfo patch > - some code cleanups > > Marc-André Lureau (5): > fw_cfg: fix the command line module name > fw_cfg: add DMA register > fw_cfg: do DMA read operation > crash: export paddr_vmcoreinfo_note() > fw_cfg: write vmcoreinfo details > > drivers/firmware/qemu_fw_cfg.c | 292 +++++++++++++++++++++++++++++++++++++---- > kernel/crash_core.c | 1 + > 2 files changed, 264 insertions(+), 29 deletions(-) > > -- > 2.15.0.rc0.40.gaefcc5f6f >