From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751174AbdKLV3h (ORCPT ); Sun, 12 Nov 2017 16:29:37 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:47198 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751099AbdKLV3f (ORCPT ); Sun, 12 Nov 2017 16:29:35 -0500 X-Google-Smtp-Source: AGs4zMYbFtt6JWw6f1qV5M6ZtzknFLvCBHhPLhyBy7H1rBFyVs0XvjGjQO8py0Z5uW9TvIBa5iZUjA== From: Rasmus Villemoes To: Marc Zyngier , Thomas Gleixner Cc: Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH] irqdomain: drop pointless NULL check in virq_debug_show_one Date: Sun, 12 Nov 2017 22:29:03 +0100 Message-Id: <20171112212904.28574-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We've already done data->irq and data->hwirq, and also unconditionally dereference data in the irq_data_get_irq_chip_data() call. Signed-off-by: Rasmus Villemoes --- kernel/irq/irqdomain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index ac4644e92b49..8aba7b4a2a91 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -921,8 +921,7 @@ static void virq_debug_show_one(struct seq_file *m, struct irq_desc *desc) chip = irq_data_get_irq_chip(data); seq_printf(m, "%-15s ", (chip && chip->name) ? chip->name : "none"); - seq_printf(m, data ? "0x%p " : " %p ", - irq_data_get_irq_chip_data(data)); + seq_printf(m, "0x%p ", irq_data_get_irq_chip_data(data)); seq_printf(m, " %c ", (desc->action && desc->action->handler) ? '*' : ' '); direct = (irq == hwirq) && (irq < domain->revmap_direct_max_irq); -- 2.11.0