From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385AbdKLXPZ (ORCPT ); Sun, 12 Nov 2017 18:15:25 -0500 Received: from mail-wr0-f172.google.com ([209.85.128.172]:50013 "EHLO mail-wr0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbdKLXPX (ORCPT ); Sun, 12 Nov 2017 18:15:23 -0500 X-Google-Smtp-Source: AGs4zMbFfGKly6Jg5NcoVABQoUXjxFMFuhIiK9wP4zmHnKQFvbFhAnPGlX+2ImWgmml1SQSzWh/oTw== From: Rasmus Villemoes To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rasmus Villemoes Subject: [PATCH 0/7] net: core: devname allocation cleanups Date: Mon, 13 Nov 2017 00:15:03 +0100 Message-Id: <20171112231511.4666-1-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's somewhat confusing to have both dev_alloc_name and dev_get_valid_name. I can't see why the former is less strict than the latter, so make them (or rather dev_alloc_name_ns and dev_get_valid_name) equivalent, hardening dev_alloc_name() a little. Obvious follow-up patches would be to only export one function, and make dev_alloc_name a static inline wrapper for that (whichever name is chosen for the exported interface). But maybe there is a good reason the two exported interfaces do different checking, so I'll refrain from including the trivial but tree-wide renaming in this series. Rasmus Villemoes (7): net: core: improve sanity checking in __dev_alloc_name net: core: move dev_alloc_name_ns a little higher net: core: eliminate dev_alloc_name{,_ns} code duplication net: core: drop pointless check in __dev_alloc_name net: core: check dev_valid_name in __dev_alloc_name net: core: maybe return -EEXIST in __dev_alloc_name net: core: dev_get_valid_name is now the same as dev_alloc_name_ns net/core/dev.c | 62 +++++++++++++++++++++------------------------------------- 1 file changed, 22 insertions(+), 40 deletions(-) -- 2.11.0