From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbdKMIMI (ORCPT ); Mon, 13 Nov 2017 03:12:08 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:48014 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751261AbdKMIMH (ORCPT ); Mon, 13 Nov 2017 03:12:07 -0500 X-Google-Smtp-Source: AGs4zMYfQ4bUEbtEXam8l1nh+5lkkx8BAgscpHBPhP2RhJy3rzZGdvlX5CkIXEFYL2i2VPXrsRC8vw== Date: Mon, 13 Nov 2017 09:12:03 +0100 From: Ingo Molnar To: Ricardo Neri Cc: Thomas Gleixner , "H. Peter Anvin" , Borislav Petkov , Andy Lutomirski , Tony Luck , Paolo Bonzini , "Ravi V. Shankar" , x86@kernel.org, ricardo.neri@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] x86/umip: Identify the str and sldt instructions Message-ID: <20171113081203.qi54w55vwrmic4mw@gmail.com> References: <1510541769-21064-1-git-send-email-ricardo.neri-calderon@linux.intel.com> <1510541769-21064-4-git-send-email-ricardo.neri-calderon@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510541769-21064-4-git-send-email-ricardo.neri-calderon@linux.intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ricardo Neri wrote: > The instructions str and sldt are not emulated in any case. Thus, it made > sense to not implement functionality to identify them. However, a > subsequent commit will introduce functionality to warn about the use of > all the instructions that UMIP protect, not only those that are emulated. > A first step for that is the ability to identify them. > > Plus, now that str and sldt are identified, we need to explicitly avoid > their emulation (i.e., not rely on unsuccessful identification). Group > togehter all the cases that we do not want to emulate: str, sldt and user > long mode processes. Did you notice how in all your previous patches (both in the code and in the changelogs) I have manually fixed up the capitalization of these instruction mnenonics? The capitalized form is much more readable, especially with seriously overloaded acronyms such as 'str' ... You now repeat the same bad pattern, in fact you regress existing code: > - /* SLDT AND STR are not emulated */ > + /* Do not emulate sldt, str or user long mode processes. */ Please be more careful with such details, and please fix & resend this series. Thanks, Ingo