From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752067AbdKMJCm (ORCPT ); Mon, 13 Nov 2017 04:02:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54366 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbdKMJCj (ORCPT ); Mon, 13 Nov 2017 04:02:39 -0500 Date: Mon, 13 Nov 2017 10:02:37 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v1 2/5] perf, tools: Save event scaling factors in perf.data Message-ID: <20171113090237.GB21325@krava> References: <20171109145528.23371-1-andi@firstfloor.org> <20171109145528.23371-3-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171109145528.23371-3-andi@firstfloor.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 13 Nov 2017 09:02:39 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 09, 2017 at 06:55:25AM -0800, Andi Kleen wrote: > From: Andi Kleen > > To process metrics, perf script needs to know the scaling > factors reported by sysfs for events. Save the scaling factors > in the perf.data metadata in a new SCALE header. > > Signed-off-by: Andi Kleen there's event_update event for scale and some other evsel stuff that was before we were able to put header through pipe it might be less code changes.. sythesize it via: if (has_scale(counter)) { err = perf_event__synthesize_event_update_scale(NULL, counter, process_synthesized_event); if (err < 0) { pr_err("Couldn't synthesize evsel scale.\n"); return err; } } and new tool's event_update callback, which is already implemented in perf_event__process_event_update having event instead of header feature might have other drawbacks.. not sure it will fit here jirka