From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752320AbdKMJM3 (ORCPT ); Mon, 13 Nov 2017 04:12:29 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35036 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752291AbdKMJM1 (ORCPT ); Mon, 13 Nov 2017 04:12:27 -0500 X-Google-Smtp-Source: AGs4zMYGqUxXIBa+umsOEFC3PSXjuc2/rGTNC3Su4ec+Qbordt/jLeLYlKEI67EdF9unGOs9ymFYyA== Date: Mon, 13 Nov 2017 09:12:23 +0000 From: Lee Jones To: Johan Hovold Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Peter Ujfalusi Subject: Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup Message-ID: <20171113091223.til75bn3smopzjix@dell> References: <20171111153844.16741-1-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171111153844.16741-1-johan@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Nov 2017, Johan Hovold wrote: > A helper purported to look up a child node based on its name was using > the wrong of-helper and ended up prematurely freeing the parent of-node > while leaking any matching node. > > To make things worse, any matching node would not even necessarily be a > child node as the whole device tree was searched depth-first starting at > the parent. > > Fixes: 019a7e6b7b31 ("mfd: twl4030-audio: Add DT support") > Cc: stable # 3.7 > Cc: Peter Ujfalusi > --- > drivers/mfd/twl4030-audio.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones I'll pick this up later in the cycle. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog