From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdKMJSj (ORCPT ); Mon, 13 Nov 2017 04:18:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:33946 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbdKMJSg (ORCPT ); Mon, 13 Nov 2017 04:18:36 -0500 Date: Mon, 13 Nov 2017 10:18:35 +0100 From: Jan Kara To: Chao Yu Cc: jack@suse.com, linux-kernel@vger.kernel.org, chao@kernel.org Subject: Re: [PATCH] quota: be aware of error from dquot_initialize Message-ID: <20171113091835.GA24824@quack2.suse.cz> References: <20171113033148.25464-1-yuchao0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113033148.25464-1-yuchao0@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 13-11-17 11:31:48, Chao Yu wrote: > Commit 6184fc0b8dd7 ("quota: Propagate error from ->acquire_dquot()") > missed to handle error from dquot_initialize in dquot_file_open, fix it. > > Signed-off-by: Chao Yu Good spotting. I've added the patch to my tree. Honza > --- > fs/quota/dquot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c > index 50b0556a124f..80002c094647 100644 > --- a/fs/quota/dquot.c > +++ b/fs/quota/dquot.c > @@ -2133,7 +2133,7 @@ int dquot_file_open(struct inode *inode, struct file *file) > > error = generic_file_open(inode, file); > if (!error && (file->f_mode & FMODE_WRITE)) > - dquot_initialize(inode); > + error = dquot_initialize(inode); > return error; > } > EXPORT_SYMBOL(dquot_file_open); > -- > 2.15.0.55.gc2ece9dc4de6 > > -- Jan Kara SUSE Labs, CR