From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbdKMJts (ORCPT ); Mon, 13 Nov 2017 04:49:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:32804 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdKMJtr (ORCPT ); Mon, 13 Nov 2017 04:49:47 -0500 Date: Mon, 13 Nov 2017 10:49:53 +0100 From: Greg KH To: Martijn Coenen Cc: john.stultz@linaro.org, tkjos@google.com, arve@android.com, amit.pundir@linaro.org, devel@driverdev.osuosl.org, maco@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ANDROID: binder: show high watermark of alloc->pages. Message-ID: <20171113094953.GB22645@kroah.com> References: <20171113090656.60754-1-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171113090656.60754-1-maco@android.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 10:06:56AM +0100, Martijn Coenen wrote: > Show the high watermark of the index into the alloc->pages > array, to facilitate sizing the buffer on a per-process > basis. > > Signed-off-by: Martijn Coenen > --- > drivers/android/binder_alloc.c | 4 ++++ > drivers/android/binder_alloc.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c > index 6f6f745605af..0dba2308125c 100644 > --- a/drivers/android/binder_alloc.c > +++ b/drivers/android/binder_alloc.c > @@ -281,6 +281,9 @@ static int binder_update_page_range(struct binder_alloc *alloc, int allocate, > goto err_vm_insert_page_failed; > } > > + if (index + 1 > alloc->pages_high) > + alloc->pages_high = index + 1; > + > trace_binder_alloc_page_end(alloc, index); > /* vm_insert_page does not seem to increment the refcount */ > } > @@ -853,6 +856,7 @@ void binder_alloc_print_pages(struct seq_file *m, > } > mutex_unlock(&alloc->mutex); > seq_printf(m, " pages: %d:%d:%d\n", active, lru, free); > + seq_printf(m, " pages high watermark: %zu\n", alloc->pages_high); Who can use this? A userspace tool? Or something else? This is ok for 4.15-rc1, right? thanks, greg k-h