From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752736AbdKMOAd (ORCPT ); Mon, 13 Nov 2017 09:00:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58492 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdKMOAc (ORCPT ); Mon, 13 Nov 2017 09:00:32 -0500 Date: Mon, 13 Nov 2017 15:00:38 +0100 From: Greg Kroah-Hartman To: Rasmus Villemoes Cc: Kees Cook , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] USB: Add format_template attribute to struct usb_class_driver Message-ID: <20171113140038.GA3436@kroah.com> References: <20171112211911.27779-1-linux@rasmusvillemoes.dk> <20171112211911.27779-5-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171112211911.27779-5-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 12, 2017 at 10:19:11PM +0100, Rasmus Villemoes wrote: > This serves as human-readable documentation as well as allowing the > format_template plugin to complain about any static initializers of this > struct member that do not have the same set of printf specifiers. > > Signed-off-by: Rasmus Villemoes > --- > include/linux/usb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/usb.h b/include/linux/usb.h > index 9c63792a8134..8d48c0cd1c01 100644 > --- a/include/linux/usb.h > +++ b/include/linux/usb.h > @@ -1236,7 +1236,7 @@ extern struct bus_type usb_bus_type; > * parameters used for them. > */ > struct usb_class_driver { > - char *name; > + char *name __format_template("foobar_%d"); > char *(*devnode)(struct device *dev, umode_t *mode); > const struct file_operations *fops; > int minor_base; Acked-by: Greg Kroah-Hartman