From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Kees Cook <keescook@chromium.org>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: speakup: Apply format_template attribute
Date: Mon, 13 Nov 2017 15:00:50 +0100 [thread overview]
Message-ID: <20171113140050.GB3436@kroah.com> (raw)
In-Reply-To: <20171112211911.27779-3-linux@rasmusvillemoes.dk>
On Sun, Nov 12, 2017 at 10:19:09PM +0100, Rasmus Villemoes wrote:
> This serves as human-readable documentation as well as allowing the
> format_template plugin to complain about any static initializers of this
> struct member that do not have the same set of printf specifiers.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/staging/speakup/spk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index c50de6035a9a..156000c0c4d3 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -108,7 +108,7 @@ struct st_var_header {
> };
>
> struct num_var_t {
> - char *synth_fmt;
> + char *synth_fmt __format_template("%d");
> int default_val;
> int low;
> int high;
> --
> 2.11.0
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-11-13 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 21:19 [PATCH 1/5] plugins: implement " Rasmus Villemoes
2017-11-12 21:19 ` [PATCH 2/5] hwmon: (applesmc) Apply " Rasmus Villemoes
2017-11-12 21:19 ` [PATCH 3/5] staging: speakup: " Rasmus Villemoes
2017-11-13 14:00 ` Greg Kroah-Hartman [this message]
2017-11-12 21:19 ` [PATCH 4/5] linux/smpboot.h: " Rasmus Villemoes
2017-11-12 23:01 ` Thomas Gleixner
2017-11-12 21:19 ` [PATCH 5/5] USB: Add format_template attribute to struct usb_class_driver Rasmus Villemoes
2017-11-13 14:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113140050.GB3436@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=speakup@linux-speakup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®