From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753152AbdKMPKg (ORCPT ); Mon, 13 Nov 2017 10:10:36 -0500 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:18373 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752734AbdKMPKe (ORCPT ); Mon, 13 Nov 2017 10:10:34 -0500 From: alexander.levin@verizon.com X-Host: surveyor.tdc.vzwcorp.com To: Alexander Sverdlin CC: Mengting Zhang , "ben@decadent.org.uk" , "linux-kernel@vger.kernel.org" , "huawei.libin@huawei.com" Subject: Re: [PATCH] lockdep: Add missing declaration of 'pr_cont()' Thread-Topic: [PATCH] lockdep: Add missing declaration of 'pr_cont()' Thread-Index: AQHTXJFfIvaGyLvsLk+oUHLAoSIwVA== Date: Mon, 13 Nov 2017 15:09:17 +0000 Message-ID: <20171113150914.kpgtalzgssx44do3@sasha-lappy> References: <1510021460-27615-1-git-send-email-zhangmengting@huawei.com> <1510071007.4450.13.camel@Nokia-N900> In-Reply-To: <1510071007.4450.13.camel@Nokia-N900> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: NeoMutt/20170113 (1.7.2) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.144.60.250] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <0D7DE1AE8EA6FF428AA4CA33F47A4DC2@vzwcorp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vADFAe5u026311 On Tue, Nov 07, 2017 at 05:10:07PM +0100, Alexander Sverdlin wrote: >Hello! > >On Tue Nov  7 03:24:20 2017 Mengting Zhang wrote: >> An annoying compile warning due to missing declaration is shown below: >> In file included from lockdep.c:27:0: >> ../../../kernel/locking/lockdep.c: In function >> 'print_unlock_imbalance_bug' : ../../../kernel/locking/lockdep.c:3544:2: >> warning: implicit declaration of function 'pr_cont' >> [-Wimplicit-function-declaration]  pr_cont(") at:\n");  ^ >> Adding the declaration of 'pr_cont' fixes the problem. >> >> Signed-off-by: Mengting Zhang > >Your commit brought my attention to the fact that commit 681fbec881 brought a regression, rendering 20fb654ae fix ineffective. > >But this is not related to your change, which I believe is correct: >Reviewed-by: Alexander Sverdlin Thanks! Queued up. -- Thanks, Sasha