From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbdKMSWR (ORCPT ); Mon, 13 Nov 2017 13:22:17 -0500 Received: from 19pmail.ess.barracuda.com ([64.235.150.244]:46464 "EHLO 19pmail.ess.barracuda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbdKMSWQ (ORCPT ); Mon, 13 Nov 2017 13:22:16 -0500 Date: Mon, 13 Nov 2017 18:21:34 +0000 From: James Hogan To: David Daney CC: , , , "Steven J. Hill" Subject: Re: [PATCH] MIPS: Add iomem resource for kernel bss section. Message-ID: <20171113182134.GD31917@jhogan-linux.mipstec.com> References: <20171012195034.5758-1-david.daney@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20171012195034.5758-1-david.daney@cavium.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [192.168.154.110] X-BESS-ID: 1510597329-637138-17934-214624-3 X-BESS-VER: 2017.14-r1710272128 X-BESS-Apparent-Source-IP: 12.201.5.28 X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.186883 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 12, 2017 at 12:50:34PM -0700, David Daney wrote: > The kexec/kdump tools need to know where the .bss is so it can be > included in the core dump. This allows vmcore-dmesg to have access to > the dmesg buffers of the crashed kernel as well as allowing the > debugger to examine variables in the bss section. > > Add a request for the bss resource in addition to the already > requested code and data sections. > > Signed-off-by: David Daney Thanks, applied. Cheers James > --- > arch/mips/kernel/setup.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c > index fe39397..702c678 100644 > --- a/arch/mips/kernel/setup.c > +++ b/arch/mips/kernel/setup.c > @@ -80,6 +80,7 @@ EXPORT_SYMBOL(mips_io_port_base); > > static struct resource code_resource = { .name = "Kernel code", }; > static struct resource data_resource = { .name = "Kernel data", }; > +static struct resource bss_resource = { .name = "Kernel bss", }; > > static void *detect_magic __initdata = detect_memory_region; > > @@ -927,6 +928,8 @@ static void __init resource_init(void) > code_resource.end = __pa_symbol(&_etext) - 1; > data_resource.start = __pa_symbol(&_etext); > data_resource.end = __pa_symbol(&_edata) - 1; > + bss_resource.start = __pa_symbol(&__bss_start); > + bss_resource.end = __pa_symbol(&__bss_stop) - 1; > > for (i = 0; i < boot_mem_map.nr_map; i++) { > struct resource *res; > @@ -966,6 +969,7 @@ static void __init resource_init(void) > */ > request_resource(res, &code_resource); > request_resource(res, &data_resource); > + request_resource(res, &bss_resource); > request_crashkernel(res); > } > } > -- > 2.9.5 >