From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754527AbdKMSbX (ORCPT ); Mon, 13 Nov 2017 13:31:23 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:29700 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbdKMSbS (ORCPT ); Mon, 13 Nov 2017 13:31:18 -0500 Date: Mon, 13 Nov 2017 21:30:29 +0300 From: Dan Carpenter To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, Bhumika Goyal , Fabian Frederick , Jaroslav Kysela , Takashi Iwai , Takashi Sakamoto , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/4] ALSA: cs46xx: Adjust 33 function calls together with a variable assignment Message-ID: <20171113183029.sudeyhgh7v6buukx@mwanda> References: <893b1dc2-d078-9ea6-4ad2-0e0327affddd@users.sourceforge.net> <5da69abe-0bcd-e2c3-cb11-04b44b4f8bd2@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5da69abe-0bcd-e2c3-cb11-04b44b4f8bd2@users.sourceforge.net> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 07:22:30PM +0100, SF Markus Elfring wrote: > - > - if ( (cpcm->pcm_channel = cs46xx_dsp_create_pcm_channel (chip, sample_rate, cpcm, > - cpcm->hw_buf.addr, > - cpcm->pcm_channel_id)) == NULL) { > + cpcm > + ->pcm_channel = cs46xx_dsp_create_pcm_channel(chip, ^^^^^^^^^^^^^ Please don't break it up like this > + sample_rate, > + cpcm, > + cpcm->hw_buf.addr, > + cpcm > + ->pcm_channel_id); ^^^^^^^^^^^^^^^^ or this. It's better to go over 80 characters than to do that. regards, dan carpenter