From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbdKMWq4 (ORCPT ); Mon, 13 Nov 2017 17:46:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32461 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753108AbdKMWqx (ORCPT ); Mon, 13 Nov 2017 17:46:53 -0500 Date: Mon, 13 Nov 2017 16:46:51 -0600 From: Josh Poimboeuf To: Andy Lutomirski Cc: X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds Subject: Re: [RFC 7/7] x86/unwind/64: Add support for the SYSENTER stack Message-ID: <20171113224651.kjeh5wbb2xadf6xb@treble> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 13 Nov 2017 22:46:53 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 10, 2017 at 08:05:26PM -0800, Andy Lutomirski wrote: > Signed-off-by: Andy Lutomirski I would make the subject more specific and less unwinder-centric, like: "x86/dumpstack: Add get_stack_info() support for the SYSENTER stack" since there aren't yet any changes to the unwinders themselves (which I'm assuming will be needed once you start using the stack). Also, at least a one-sentence description would be good. Otherwise the patch looks good to me. -- Josh