From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754501AbdKNMfd (ORCPT ); Tue, 14 Nov 2017 07:35:33 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:39858 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751593AbdKNMf0 (ORCPT ); Tue, 14 Nov 2017 07:35:26 -0500 Date: Tue, 14 Nov 2017 21:35:22 +0900 (KST) Message-Id: <20171114.213522.969210371302346148.davem@davemloft.net> To: bianpan2016@163.com Cc: andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] net: dsa: lan9303: correctly check return value of devm_gpiod_get_optional From: David Miller In-Reply-To: <1510501089-9451-1-git-send-email-bianpan2016@163.com> References: <1510501089-9451-1-git-send-email-bianpan2016@163.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Nov 2017 04:35:26 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pan Bian Date: Sun, 12 Nov 2017 23:38:09 +0800 > Function devm_gpiod_get_optional() returns an ERR_PTR on failure. Its > return value should not be validated by a NULL check. Instead, use IS_ERR. > > Signed-off-by: Pan Bian Applied.