From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753551AbdKNHWH (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 02:22:07 -0500
Received: from mail-wm0-f68.google.com ([74.125.82.68]:38686 "EHLO
        mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752644AbdKNHWB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 02:22:01 -0500
X-Google-Smtp-Source: AGs4zMZufJpgNWSrXkrKhDftnfgnzZ1FVj0M+BVmk6xL7D7EPFHYYgpslOzqpQ0pdbYt+PKdbBlJ3g==
Date: Tue, 14 Nov 2017 08:21:57 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
        Tony Luck <tony.luck@intel.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>, x86@kernel.org,
        ricardo.neri@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 3/4] x86/umip: Identify the str and sldt
 instructions
Message-ID: <20171114072157.f4knhqouiflj5drr@gmail.com>
References: <1510640985-18412-1-git-send-email-ricardo.neri-calderon@linux.intel.com>
 <1510640985-18412-4-git-send-email-ricardo.neri-calderon@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1510640985-18412-4-git-send-email-ricardo.neri-calderon@linux.intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:

> The instructions STR and SLDT are not emulated in any case. Thus, it made
> sense to not implement functionality to identify them. However, a
> subsequent commit will introduce functionality to warn about the use of
> all the instructions that UMIP protect, not only those that are emulated.
> A first step for that is the ability to identify them.
> 
> Plus, now that STR and SLDT are identified, we need to explicitly avoid
> their emulation (i.e., not rely on unsuccessful identification). Group
> togehter all the cases that we do not want to emulate: STR, SLDT and user
> long mode processes.
> 
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Ravi V. Shankar <ravi.v.shankar@intel.com>
> Cc: x86@kernel.org
> Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>

Sigh, the _title_ still refers to 'str'...

I'll fix it up, no need to resend, but this lack of attention to details is 
seriously sad.

Thanks,

	Ingo