From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbdKNImq (ORCPT ); Tue, 14 Nov 2017 03:42:46 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:12947 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751466AbdKNImh (ORCPT ); Tue, 14 Nov 2017 03:42:37 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171114084235epoutp0216c54a470b1e7b9104f8c64e0056736f~25ziiR8cf3032230322epoutp02I X-AuditID: b6c32a45-333ff70000001129-65-5a0aac7bde66 From: Jaewon Kim To: hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, gregkh@linuxfoundation.org, iommu@lists.linux-foundation.org Cc: akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com, Jaewon Kim Subject: [RFC PATCH] drivers: base: dma-coherent: find free region without alignment Date: Tue, 14 Nov 2017 17:42:29 +0900 Message-id: <20171114084229.13512-1-jaewon31.kim@samsung.com> X-Mailer: git-send-email 2.13.0 X-Brightmail-Tracker: H4sIAAAAAAAAAzWSa0hTYRjHez3bOdtycZhWbwa1TjcyXDunzR1Nu9CFQxeUipCFrJOepuQu 7EzJilqKIjOttA+mS4Q+VDYZTtGZlTSvlFlmRoKWRUVIN2ZlaGbbjn37/d/n/3+fh4dHgiie i2Mk2WY7ZzOzOQQqE7V0bqDjzrhlevVwDUa7PG6ULrzhQenbd7oj6LqOLXRp0zVAl32biKCH 7rpQ+rV7Tkw3dI1h9Jvy7fTD7+/FdM2FcrA9knHXugHTVj2GMd5ABcb0Vc2ImI7rboypfHUT MO0jDpQpb64HjKd5WMT013VhzKR3RepCPZeUxbGZnE3JmTMsmdlmYzKx75Bhp0EbrybjyARa RyjNrIlLJnbtT43bk50TnJ1Q5rE5ucGnVJbniU1bk2yWXDunzLLw9mTiKElSKlKtU1EUpdLo 0hMpbdByjMsae/tFZO1ZdMo3Mi1ygJmFTiCRQFwD/T15TiCTKHAfgKPVvYggpgC8Vz8e4QTS sOlRaaVYKLQDOODrBoKYA/D7yM+wC8U3wm91FeIQR+Pn4NdKBxoyIXgTgEW/fmChQhR+BE64 XoIQi/C1cPxqIRJiOZ4MZwKFqNBuJXwxfUkUCkO8C4X9/oL5OXbBx6NOscBRcKK3GRN4OfxY 3wiEQCmAFxs984GSoBjPFngzDExOhjsj+CJY0jmLCRuQw5JihWBhYNVf7/yfO+CT9w3hgRR4 Oqx90YRcBsvqwIJ6sISz8iYjx1NWUsWzJj7XbFRlWExeEL6n2N0+UDWw3w9wCSAi5Z8GpXqF mM3j801+ACUIES1vq5bpFfJMNv80Z7MYbLk5HO8H2uA+riAxizMswes02w2kJkGtiY8ndZRW rSOWys+3vExT4EbWzp3kOCtn+5+LkEhjHGDNSn3Ms9F1H4q1ZVIXdfPK9FY51QU8PsNUwKKS Ddy6X5I6PaGZfXC8wgtPrP6j/dxa9KFD+8qX9rNhs7dPumr9wcM1gcT8gm3DT2fbhi4fOHWy zNpU45y9lfL8thNMbXOk7I59d87d0DhYuvzA0N5I6dnfa/4YXcoUd6Vibia/lRDxWSwZi9h4 9h+T1xOqZQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsVy+t9jAd2qNVxRBtMmGFrMWb+GzaJ58Xo2 i5WrjzJZLNhvbdG9eSajRe/7V0wWl3fNYbO4t+Y/q8XaI3fZLe73OVgc/PCE1WJ2Yx+jA4/H mnlrGD12zrrL7rHp0yR2jxMzfrN47J+7ht1j8o3ljB67bzawefRtWcXosX7LVRaPMwuOsHt8 3iQXwB3FZZOSmpNZllqkb5fAlXH34VuWgmN8FTtu/mJpYPzN3cXIySEhYCJxqnsyK4gtJLCT UeJbu3UXIxeQ3cgksbv3FjtIgk1AW+L9gklARRwcIgJ1ErcmcIHUMAtsZpT4OHMpM0iNsECY xKs51xhBbBYBVYkHU5rB4rwCthK/PzWzQSyTl7jyq59lAiPXAkaGVYySqQXFuem5xUYFRnmp 5XrFibnFpXnpesn5uZsYgeG37bBW/w7Gx0viDzEKcDAq8fA6XOGMEmJNLCuuzD3EKMHBrCTC u3MWV5QQb0piZVVqUX58UWlOavEhRmkOFiVxXv78Y5FCAumJJanZqakFqUUwWSYOTqkGxoit M4SD0ziacvaunFR4+IjbxEPnTNxPMC0JDzncOWFz64qvpozPzWdtnNjxs2n9+vpE6yf/+DyO z70knfM1wMHqWrH1px3+ogVsKSlpGpODN0UeNGb8MeeEWf7ZezadifkH5HOyztk88px0sNn2 7/Z5YU82173Tm3l+Gf+5u2aZJXNEHVfPyVJiKc5INNRiLipOBADJfhV0OwIAAA== X-CMS-MailID: 20171114084234epcas2p44ac00494b49aa798f709c5bbdf92127a X-Msg-Generator: CA CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20171114084234epcas2p44ac00494b49aa798f709c5bbdf92127a X-RootMTR: 20171114084234epcas2p44ac00494b49aa798f709c5bbdf92127a References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma-coherent uses bitmap API which internally consider align based on the requested size. Depending on some usage pattern, using align, I think, may be good for fast search and anti-fragmentation. But with the align, an allocation may be failed. This is a example, total size is 30MB, only few memory at front is being used, and 9MB is being requsted. Then 9MB will be aligned to 16MB. The first try on offset 0MB will be failed because of others already using. The second try on offset 16MB will be failed because of ouf of bound. So if the align is not necessary on dma-coherent, this patch removes the align policy to allow allocation without increasing the total size. Signed-off-by: Jaewon Kim --- drivers/base/dma-coherent.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/base/dma-coherent.c b/drivers/base/dma-coherent.c index 744f64f43454..b86a96d0cd07 100644 --- a/drivers/base/dma-coherent.c +++ b/drivers/base/dma-coherent.c @@ -162,7 +162,7 @@ EXPORT_SYMBOL(dma_mark_declared_memory_occupied); static void *__dma_alloc_from_coherent(struct dma_coherent_mem *mem, ssize_t size, dma_addr_t *dma_handle) { - int order = get_order(size); + int nr_page = PAGE_ALIGN(size) >> PAGE_SHIFT; unsigned long flags; int pageno; void *ret; @@ -172,9 +172,11 @@ static void *__dma_alloc_from_coherent(struct dma_coherent_mem *mem, if (unlikely(size > (mem->size << PAGE_SHIFT))) goto err; - pageno = bitmap_find_free_region(mem->bitmap, mem->size, order); - if (unlikely(pageno < 0)) + pageno = bitmap_find_next_zero_area(mem->bitmap, mem->size, 0, + nr_page, 0); + if (unlikely(pageno >= mem->size)) { goto err; + bitmap_set(mem->bitmap, pageno, nr_page); /* * Memory was found in the coherent area. -- 2.13.0