From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754898AbdKNLbr (ORCPT ); Tue, 14 Nov 2017 06:31:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50828 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753125AbdKNLbj (ORCPT ); Tue, 14 Nov 2017 06:31:39 -0500 Date: Tue, 14 Nov 2017 12:31:44 +0100 From: "gregkh@linuxfoundation.org" To: Russell King - ARM Linux Cc: Oleksandr Shamray , "devicetree@vger.kernel.org" , "jiri@resnulli.us" , "'Chip Bilbrey'" , "arnd@arndb.de" , "linux-api@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "openocd-devel-owner@lists.sourceforge.net" , "mec@shout.net" , Jiri Pirko , "robh+dt@kernel.org" , "joel@jms.id.au" , "linux-serial@vger.kernel.org" , "tklauser@distanz.ch" , "mchehab@kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [v11,1/4] drivers: jtag: Add JTAG core driver Message-ID: <20171114113144.GA25234@kroah.com> References: <1509724449-26221-2-git-send-email-oleksandrs@mellanox.com> <8760aoz78q.fsf@bilbrey.org> <20171114111046.GA23820@kroah.com> <20171114111916.GO12318@n2100.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171114111916.GO12318@n2100.armlinux.org.uk> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2017 at 11:19:16AM +0000, Russell King - ARM Linux wrote: > On Tue, Nov 14, 2017 at 12:10:46PM +0100, gregkh@linuxfoundation.org wrote: > > On Tue, Nov 14, 2017 at 10:34:49AM +0000, Oleksandr Shamray wrote: > > > Greg, what you can suggest about it. May be better to add again single-open()-per-device lock with right locking way like: > > > > > > >if (mutex_lock_interruptible(&jtag->open_lock)) { > > > > You would stall an open? Why not just return saying you can't do that? > > Greg, I think you need to look at the code again. Heh, sorry, I probably got it wrong. I'll be glad to review it in a real patch when needed, but not in the middle of the merge window :) thanks, greg k-h