From: Mark Brown <broonie@kernel.org>
To: Tim Harvey <tharvey@gateworks.com>
Cc: Jan Glauber <jan.glauber@caviumnetworks.com>,
linux-spi@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: MCP251x SPI CAN controller on Cavium ThunderX
Date: Tue, 14 Nov 2017 12:02:07 +0000 [thread overview]
Message-ID: <20171114120207.xbee2cgsai4qka46@sirena.org.uk> (raw)
In-Reply-To: <CAJ+vNU3VK=NPKW+119t4MT7w5xs=FS2HWJTqbFb-HSeJhCvwWw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Mon, Nov 13, 2017 at 01:17:42PM -0800, Tim Harvey wrote:
> When a register is read from the mcp251x driver the
> octeon_spi_do_transfer() gets a spi_message with a single spi_xfer of
> len=3, a tx_buf, and an rx_buf which I believe is supposed to shift
> out 3 bytes out MOSI and shift in 3 bytes from MISO where the last
> byte shifted in would be the response.
No, that will simultaneously transmit and recieve three bytes. If you
want to transmit two bytes and then recieve one byte you need two xfers,
one with a len of 2 and a tx_buf, the other with a len of 1 and a rx_buf.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-11-14 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 21:17 Tim Harvey
2017-11-14 12:02 ` Mark Brown [this message]
2017-11-15 10:54 ` Marc Kleine-Budde
2017-11-15 12:07 ` Jan Glauber
2017-11-15 12:40 ` Marc Kleine-Budde
2017-11-15 13:31 ` Marc Kleine-Budde
2017-11-15 14:24 ` Jan Glauber
2017-11-15 15:39 ` Mark Brown
2017-11-15 16:02 ` David Daney
2017-11-15 18:23 ` Tim Harvey
2017-11-15 23:18 ` Tim Harvey
2017-11-16 12:12 ` Marc Kleine-Budde
2017-11-16 16:13 ` Tim Harvey
2017-11-16 12:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114120207.xbee2cgsai4qka46@sirena.org.uk \
--to=broonie@kernel.org \
--cc=jan.glauber@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=tharvey@gateworks.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®