From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755330AbdKNN5j (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 08:57:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37364 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752887AbdKNN5b (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 08:57:31 -0500
Date: Tue, 14 Nov 2017 14:57:22 +0100
From: Cornelia Huck <cohuck@redhat.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com,
        heiko.carstens@de.ibm.com, borntraeger@de.ibm.com,
        kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com,
        alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com,
        alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com,
        qemu-s390x@nongnu.org, jjherne@linux.vnet.ibm.com, thuth@redhat.com,
        pasic@linux.vnet.ibm.com
Subject: Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto
 adapters
Message-ID: <20171114145722.4ab850a5.cohuck@redhat.com>
In-Reply-To: <5baf5f90-6cac-3c09-7b66-1bc8b30b8093@linux.vnet.ibm.com>
References: <1507916344-3896-1-git-send-email-akrowiak@linux.vnet.ibm.com>
        <5baf5f90-6cac-3c09-7b66-1bc8b30b8093@linux.vnet.ibm.com>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 14 Nov 2017 13:57:30 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 31 Oct 2017 15:39:09 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:

> On 10/13/2017 01:38 PM, Tony Krowiak wrote:
> Ping

> > Tony Krowiak (19):
> >    KVM: s390: SIE considerations for AP Queue virtualization
> >    KVM: s390: refactor crypto initialization
> >    s390/zcrypt: new AP matrix bus
> >    s390/zcrypt: create an AP matrix device on the AP matrix bus
> >    s390/zcrypt: base implementation of AP matrix device driver
> >    s390/zcrypt: register matrix device with VFIO mediated device
> >      framework
> >    KVM: s390: introduce AP matrix configuration interface
> >    s390/zcrypt: support for assigning adapters to matrix mdev
> >    s390/zcrypt: validate adapter assignment
> >    s390/zcrypt: sysfs interfaces supporting AP domain assignment
> >    s390/zcrypt: validate domain assignment
> >    s390/zcrypt: sysfs support for control domain assignment
> >    s390/zcrypt: validate control domain assignment
> >    KVM: s390: Connect the AP mediated matrix device to KVM
> >    s390/zcrypt: introduce ioctl access to VFIO AP Matrix driver
> >    KVM: s390: interface to configure KVM guest's AP matrix
> >    KVM: s390: validate input to AP matrix config interface
> >    KVM: s390: New ioctl to configure KVM guest's AP matrix
> >    s390/facilities: enable AP facilities needed by guest

I think the approach is fine, and the code also looks fine for the most
part. Some comments:

- various patches can be squashed together to give a better
  understanding at a glance
- this needs documentation (as I already said)
- some of the driver/device modelling feels a bit awkward (commented in
  patches) -- I'm not sure that my proposal is better, but I think we
  should make sure the interdependencies are modeled correctly
- some minor stuff