From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756488AbdKNW13 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 14 Nov 2017 17:27:29 -0500
Received: from mail-wm0-f66.google.com ([74.125.82.66]:55665 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755156AbdKNW1V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Nov 2017 17:27:21 -0500
X-Google-Smtp-Source: AGs4zMYBlIYQIgazvyjQ3oc7aKDS6LWNSHxa5t2CDt5a7d57V5CJIjBoAnQ/rSD02afGTphXEt2yFg==
Date: Wed, 15 Nov 2017 01:27:18 +0300
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Nicholas Piggin <npiggin@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] x86/mm: Do not allow non-MAP_FIXED mapping across
 DEFAULT_MAP_WINDOW border
Message-ID: <20171114222718.76w4lmclf6wasbl3@node.shutemov.name>
References: <20171114134322.40321-1-kirill.shutemov@linux.intel.com>
 <alpine.DEB.2.20.1711141630210.2044@nanos>
 <20171114202102.crpgiwgv2lu5aboq@node.shutemov.name>
 <alpine.DEB.2.20.1711142131010.2221@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.20.1711142131010.2221@nanos>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 14, 2017 at 09:54:52PM +0100, Thomas Gleixner wrote:
> On Tue, 14 Nov 2017, Kirill A. Shutemov wrote:
> 
> > On Tue, Nov 14, 2017 at 05:01:50PM +0100, Thomas Gleixner wrote:
> > > @@ -198,11 +199,14 @@ arch_get_unmapped_area_topdown(struct fi
> > >  	/* requesting a specific address */
> > >  	if (addr) {
> > >  		addr = PAGE_ALIGN(addr);
> > > +		if (!mmap_address_hint_valid(addr, len))
> > > +			goto get_unmapped_area;
> > > +
> > 
> > Here and in hugetlb_get_unmapped_area(), we should align the addr after
> > the check, not before. Otherwise the alignment itself can bring us over
> > the borderline as we align up.
> 
> Hmm, then I wonder whether the next check against vm_start_gap() which
> checks against the aligned address is correct:
> 
>                 addr = PAGE_ALIGN(addr);
>                 vma = find_vma(mm, addr);
> 
>                 if (end - len >= addr &&
>                     (!vma || addr + len <= vm_start_gap(vma)))
>                         return addr;

I think the check is correct. The check is against resulting addresses
that end up in vm_start/vm_end. In our case we want to figure out what
user asked for.

-- 
 Kirill A. Shutemov