From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbdKOFTC (ORCPT ); Wed, 15 Nov 2017 00:19:02 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:53054 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754938AbdKOFSw (ORCPT ); Wed, 15 Nov 2017 00:18:52 -0500 Date: Wed, 15 Nov 2017 14:18:49 +0900 (KST) Message-Id: <20171115.141849.19410021204989663.davem@davemloft.net> To: garsilva@embeddedor.com Cc: pshelar@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] openvswitch: meter: fix NULL pointer dereference in ovs_meter_cmd_reply_start From: David Miller In-Reply-To: <20171114202616.GA10862@embeddedor.com> References: <20171114202616.GA10862@embeddedor.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Nov 2017 21:18:52 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Gustavo A. R. Silva" Date: Tue, 14 Nov 2017 14:26:16 -0600 > It seems that the intention of the code is to null check the value > returned by function genlmsg_put. But the current code is null > checking the address of the pointer that holds the value returned > by genlmsg_put. > > Fix this by properly null checking the value returned by function > genlmsg_put in order to avoid a pontential null pointer dereference. > > Addresses-Coverity-ID: 1461561 ("Dereference before null check") > Addresses-Coverity-ID: 1461562 ("Dereference null return value") > Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") > Signed-off-by: Gustavo A. R. Silva Applied.