From: alexander.levin@verizon.com
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, alexander.levin@verizon.com
Subject: [PATCH AUTOSEL for 4.4 22/28] netfilter: nft_queue: use raw_smp_processor_id()
Date: Wed, 15 Nov 2017 02:46:03 +0000 [thread overview]
Message-ID: <20171115024551.5988-22-alexander.levin@verizon.com> (raw)
In-Reply-To: <20171115024551.5988-1-alexander.levin@verizon.com>
From: Pablo Neira Ayuso <pablo@netfilter.org>
[ Upstream commit c2e756ff9e699865d294cdc112acfc36419cf5cc ]
Using smp_processor_id() causes splats with PREEMPT_RCU:
[19379.552780] BUG: using smp_processor_id() in preemptible [00000000] code: ping/32389
[19379.552793] caller is debug_smp_processor_id+0x17/0x19
[...]
[19379.552823] Call Trace:
[19379.552832] [<ffffffff81274e9e>] dump_stack+0x67/0x90
[19379.552837] [<ffffffff8129a4d4>] check_preemption_disabled+0xe5/0xf5
[19379.552842] [<ffffffff8129a4fb>] debug_smp_processor_id+0x17/0x19
[19379.552849] [<ffffffffa07c42dd>] nft_queue_eval+0x35/0x20c [nft_queue]
No need to disable preemption since we only fetch the numeric value, so
let's use raw_smp_processor_id() instead.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
---
net/netfilter/nft_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nft_queue.c b/net/netfilter/nft_queue.c
index 61d216eb7917..5d189c11d208 100644
--- a/net/netfilter/nft_queue.c
+++ b/net/netfilter/nft_queue.c
@@ -37,7 +37,7 @@ static void nft_queue_eval(const struct nft_expr *expr,
if (priv->queues_total > 1) {
if (priv->flags & NFT_QUEUE_FLAG_CPU_FANOUT) {
- int cpu = smp_processor_id();
+ int cpu = raw_smp_processor_id();
queue = priv->queuenum + cpu % priv->queues_total;
} else {
--
2.11.0
next prev parent reply other threads:[~2017-11-15 3:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 2:45 [PATCH AUTOSEL for 4.4 01/28] ACPICA: Resources: Not a valid resource if buffer length too long alexander.levin
2017-11-15 2:45 ` [PATCH AUTOSEL for 4.4 02/28] RDS: RDMA: return appropriate error on rdma map failures alexander.levin
2017-11-15 2:45 ` [PATCH AUTOSEL for 4.4 04/28] dmaengine: zx: set DMA_CYCLIC cap_mask bit alexander.levin
2017-11-15 2:45 ` [PATCH AUTOSEL for 4.4 03/28] PCI: Apply _HPX settings only to relevant devices alexander.levin
2017-11-15 2:45 ` [PATCH AUTOSEL for 4.4 05/28] net: Allow IP_MULTICAST_IF to set index to L3 slave alexander.levin
2017-11-15 2:45 ` [PATCH AUTOSEL for 4.4 06/28] net: 3com: typhoon: typhoon_init_one: make return values more specific alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 10/28] ath10k: ignore configuring the incorrect board_id alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 09/28] ath10k: fix incorrect txpower set by P2P_DEVICE interface alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 07/28] net: 3com: typhoon: typhoon_init_one: fix incorrect return values alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 08/28] drm/armada: Fix compile fail alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 11/28] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats() alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 12/28] ath10k: set CTS protection VDEV param only if VDEV is up alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 13/28] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 14/28] drm: Apply range restriction after color adjustment when allocation alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 18/28] iio: light: fix improper return value alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 15/28] mac80211: Remove invalid flag operations in mesh TSF synchronization alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 16/28] mac80211: Suppress NEW_PEER_CANDIDATE event if no room alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 17/28] drm/i915: Fix the level 0 max_wm hack on VLV/CHV alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 19/28] staging: iio: cdc: fix improper return value alexander.levin
2017-11-15 2:46 ` alexander.levin [this message]
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 23/28] netfilter: nf_tables: fix oob access alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 20/28] drm/i915/bxt: Correct dual-link MIPI port control alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 21/28] spi: SPI_FSL_DSPI should depend on HAS_DMA alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 24/28] ASoC: rsnd: don't double free kctrl alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 26/28] ASoC: wm_adsp: Don't overrun firmware file buffer when reading region data alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 25/28] btrfs: return the actual error value from from btrfs_uuid_tree_iterate alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 27/28] s390/kbuild: enable modversions for symbols exported from asm alexander.levin
2017-11-15 2:46 ` [PATCH AUTOSEL for 4.4 28/28] xen: xenbus driver must not accept invalid transaction ids alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115024551.5988-22-alexander.levin@verizon.com \
--to=alexander.levin@verizon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®