From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757263AbdKOJTw (ORCPT ); Wed, 15 Nov 2017 04:19:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:35020 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757184AbdKOJS4 (ORCPT ); Wed, 15 Nov 2017 04:18:56 -0500 Date: Wed, 15 Nov 2017 10:18:55 +0100 From: Michal Hocko To: Fan Du Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memory hotplug: fix comments when add section Message-ID: <20171115091855.tkqbex2ow3m5jpdk@dhcp22.suse.cz> References: <1510735205-22540-1-git-send-email-fan.du@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510735205-22540-1-git-send-email-fan.du@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 15-11-17 16:40:05, Fan Du wrote: > Here, pfn_to_node should be page_to_nid. > > Signed-off-by: Fan Du Yes, it is a typo. And the one worth fixing because this will make git grep great again Acked-by: Michal Hocko > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index d4b5f29..c3c1c57 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -265,7 +265,7 @@ static int __meminit __add_section(int nid, unsigned long phys_start_pfn, > /* > * Make all the pages reserved so that nobody will stumble over half > * initialized state. > - * FIXME: We also have to associate it with a node because pfn_to_node > + * FIXME: We also have to associate it with a node because page_to_nid > * relies on having page with the proper node. > */ > for (i = 0; i < PAGES_PER_SECTION; i++) { > -- > 1.8.3.1 -- Michal Hocko SUSE Labs